-
-
Notifications
You must be signed in to change notification settings - Fork 56
ci: enable all qa tools for fixtures
#363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe updates expand static analysis, code style, and dependency tracking tools to include the Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
ci/deptrac/config.yml (1)
33-48: Configure dependency rules for new layers.
Integration Tests depend on Fixtures, Functions, and Types; Unit Tests additionally depend on Utils. Rules align with the new layer definitions.Optionally, review whether Unit Tests should depend on Fixtures (to avoid over-coupling test layers), depending on how fixtures are used in your unit tests.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
ci/deptrac/config.yml(2 hunks)ci/php-cs-fixer/config.php(1 hunks)ci/phpstan/config.neon(1 hunks)fixtures/MartinGeorgiev/Doctrine/Entity/ContainsDecimals.php(1 hunks)fixtures/MartinGeorgiev/Doctrine/Function/TestVariadicFunction.php(0 hunks)
💤 Files with no reviewable changes (1)
- fixtures/MartinGeorgiev/Doctrine/Function/TestVariadicFunction.php
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: PHP 8.1 + Doctrine ORM 2.14 + Doctrine Lexer 1.2
- GitHub Check: PHP 8.4 + Doctrine ORM latest + Doctrine Lexer 3.0
- GitHub Check: PHP 8.4 + Doctrine ORM latest + Doctrine Lexer latest
- GitHub Check: PHP 8.4 + Doctrine ORM 2.18 + Doctrine Lexer 2.1
- GitHub Check: PHP 8.3 + Doctrine ORM 3.0 + Doctrine Lexer latest
- GitHub Check: sloth
🔇 Additional comments (5)
fixtures/MartinGeorgiev/Doctrine/Entity/ContainsDecimals.php (1)
21-21: Skip whitespace-only change. The only addition is a newline at end of file to satisfy POSIX requirements—no functional impact.ci/phpstan/config.neon (1)
14-17: Include fixtures in PHPStan analysis.
Adding- ../../fixturesunderparameters.pathsensures your fixtures directory is now covered by PHPStan, keeping it consistent with other CI tools.ci/php-cs-fixer/config.php (1)
11-14: Include fixtures directory in PHP CS Fixer.
The new->in($basePath.'fixtures')call extends code style checks to your fixtures, aligning this config with PHPStan and Deptrac.ci/deptrac/config.yml (2)
2-5: Include fixtures in Deptrac paths.
Adding- ../../fixturesunderdeptrac.pathsensures dependency analysis now covers your fixtures directory.
7-32: Define new Fixtures and Test layers.
The addition of "Fixtures", "Integration Tests", and "Unit Tests" layers introduces finer-grained dependency boundaries. Collectors correctly target:
\Fixtures\MartinGeorgiev\.*\Tests\Integration\MartinGeorgiev\.*\Tests\Unit\MartinGeorgiev\.*
This matches the intended namespace structure.
Summary by CodeRabbit