-
-
Notifications
You must be signed in to change notification settings - Fork 56
docs: add description for some missing functions to the documentation #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
add `FLAGGED_REGEXP_REPLACE`, `REGEXP_REPLACE`, `ROW` to symfony docs
WalkthroughThe documentation update enhances the Symfony integration by adding three new DQL string functions to the Doctrine ORM configuration: Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/INTEGRATING-WITH-SYMFONY.md (2)
170-172: New DQL Function Registrations AddedThe YAML snippet now registers the new functions:
FLAGGED_REGEXP_REPLACEmapped toMartinGeorgiev\Doctrine\ORM\Query\AST\Functions\FlaggedRegexpReplaceREGEXP_REPLACEmapped toMartinGeorgiev\Doctrine\ORM\Query\AST\Functions\RegexpReplaceROWmapped toMartinGeorgiev\Doctrine\ORM\Query\AST\Functions\RowThese entries follow the existing naming conventions and structure. Please ensure that the corresponding class implementations exist and have adequate tests covering their behavior.
170-172: Consider Adding Usage GuidanceSince this documentation update is meant to enhance clarity on integrating these functions with Symfony, it would be very helpful to include a short note or an example demonstrating how to use these functions in a DQL query. This will assist users in understanding their purpose and correct usage immediately from the configuration file.
|
Thank you @Gemorroj! Can you please add to the other docs where it's also missing? |
…nc doctrine docs like symfony/laravel

add
FLAGGED_REGEXP_REPLACE,REGEXP_REPLACE,ROWto symfony docsSummary by CodeRabbit