-
-
Notifications
You must be signed in to change notification settings - Fork 56
ci: finetune when specific workflow steps shall run #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
000712d
ci: finetune when specific workflow steps shall run
martin-georgiev 76bb351
test workflows on purpose
martin-georgiev f4b2930
Revert "test workflows on purpose"
martin-georgiev 47ccc05
test workflows on purpose
martin-georgiev 85b47e2
Update .github/workflows/ci.yml
martin-georgiev e215d8f
Update src/MartinGeorgiev/Utils/DoctrineLexer.php
martin-georgiev dff5dd6
Update src/MartinGeorgiev/Utils/DoctrineLexer.php
martin-georgiev 0d4967f
no message
martin-georgiev e6189e9
Merge branch 'workflows' of https://github.com/martin-georgiev/postgr…
martin-georgiev 5789844
no message
martin-georgiev af962e5
no message
martin-georgiev d5fc86c
no message
martin-georgiev ed5ecdd
Update .github/workflows/sloth.yml
martin-georgiev a1a2ce3
Merge branch 'workflows' of https://github.com/martin-georgiev/postgr…
martin-georgiev b53007d
Revert "Update .github/workflows/sloth.yml"
martin-georgiev b859916
no message
martin-georgiev 5ded437
no message
martin-georgiev 57b9dd4
no message
martin-georgiev 7192013
no message
martin-georgiev b8e8fe3
no message
martin-georgiev 41800d0
no message
martin-georgiev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
❓ Verification inconclusive
Condition for Uploading Coverage Results
The condition used here is
if: matrix.calculate-code-coverage == true. According to the PR objectives, the condition was updated to include a check that the event triggering the workflow is apull_request. If this was intended, please update the condition as follows:This ensures that coverage results are only uploaded when the workflow is triggered by a pull request.
Action Required: Update CI Workflow Condition for Coveralls Upload
The current condition only checks
matrix.calculate-code-coverage == true. However, based on the PR objectives, this condition should also verify that the workflow is triggered by a pull request. Please update the condition as follows:This change will ensure that coverage results are uploaded only when the workflow is triggered by a pull request.
📝 Committable suggestion