Skip to content

fix: improve BC by deprecating customiseFunction instead of renaming it straight away #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025
Merged

fix: improve BC by deprecating customiseFunction instead of renaming it straight away #294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion src/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/BaseFunction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,28 @@ abstract class BaseFunction extends FunctionNode
*/
protected array $nodes = [];

abstract protected function customizeFunction(): void;
/**
* This method is meant for internal use only, and it is not suggested that the forks of the library depend on it.
* It will be made abstract from version 3.0.
*
* @internal
*
* @see customiseFunction()
*/
/* abstract */
protected function customizeFunction(): void
{
// Void
}

/**
* @deprecated
*/
protected function customiseFunction(): void
{
\trigger_error('The internal-use method of `customiseFunction()` is deprecated and is now renamed to `customizeFunction()`. `customiseFunction()` will be removed from version 3.0 onwards.', E_USER_DEPRECATED);
$this->customizeFunction();
}

protected function setFunctionPrototype(string $functionPrototype): void
{
Expand Down