-
-
Notifications
You must be signed in to change notification settings - Fork 56
ci: fix test matrix to cover all PHP and Doctrine ORM combinations #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The CI workflow now correctly tests all combinations of: - PHP versions (8.1, 8.2, 8.3, 8.4) - Doctrine ORM versions (2.14, 3.0, latest) This creates 12 test combinations instead of separate jobs for PHP and Doctrine. Code coverage reporting remains exclusive to PHP 8.4 builds.
|
Caution Review failedThe pull request is closed. WalkthroughThe CI configuration has been updated to streamline the job matrix declarations. PHP versions have been expanded from three to four (8.1, 8.2, 8.3, 8.4) and the Doctrine ORM versions are now consolidated into a matrix with values (2.14, 3.0, latest). Additionally, individual include entries have been removed, and the PHP setup step now directly references the matrix variable rather than falling back to a hard-coded value. Changes
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
The CI workflow now correctly tests all combinations of:
This creates 12 test combinations instead of separate jobs for PHP and Doctrine. Code coverage reporting remains exclusive to PHP 8.4 builds.
Summary by CodeRabbit