feat: add multiple arguments support for ARRAY
#279
Conversation
WalkthroughThe changes introduce new script entries in the Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant A as Arr Function
participant V as ValidateArguments
U->>A: Call ARRAY function with args
A->>V: Validate arguments
alt No arguments provided
V-->>A: Throw InvalidArgumentForVariadicFunctionException
A-->>U: Return error
else Valid arguments
V-->>A: Validation success
A-->>U: Return processed result
end
Poem
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
ci/phpstan/config.neon(1 hunks)composer.json(1 hunks)
🔇 Additional comments (4)
ci/phpstan/config.neon (2)
8-8: Good addition of CI directory to PHPStan analysis paths.Including the CI scripts in static analysis is a good practice that helps identify issues in your build scripts early.
13-16: Well-structured PHPStan configuration update.The change from using the direct configuration
checkMissingIterableValueType: falseto using the identifier-based ignore system withidentifier: missingType.iterableValueis a good modernization. This follows current PHPStan best practices and allows for more granular control over ignored errors.composer.json (2)
63-77: Well-organized script definitions with clear tool configurations.Extracting individual tool commands into named scripts is an excellent practice. This improves maintainability, makes the CI configuration more readable, and allows for easier updates to tool configurations in the future.
79-82: Good refactoring of composite scripts to reference individual tool scripts.Updating the composite scripts to reference the individual tool scripts using the
@script-namesyntax is a good practice. This makes the configuration more DRY and easier to maintain.Also applies to: 83-86, 87-90, 91-93, 94-96
# Conflicts: # composer.json
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
.github/workflows/ci.yml (3)
14-14: Simplified CI Job NameUpdating the CI job name to
"PHP ${{ matrix.php }} + Doctrine ORM ${{ matrix.doctrine-orm }}"streamlines the output and better reflects the current testing strategy by removing legacy references (e.g., tocomposer-flags).
55-57: Composer Dependency Command for doctrine/orm "2.14"The conditional correctly installs
doctrine/ormwith version"~2.14"whenmatrix.doctrine-ormequals"2.14". Consider verifying that the use of==in the shell comparison behaves consistently in your CI environment; in strict POSIX shells a single=might be more portable.
57-59: Composer Dependency Command for doctrine/orm "3.0"Similarly, the conditional installs
doctrine/ormwith version"~3.0"whenmatrix.doctrine-ormis"3.0". As with the previous comment, ensure that the comparison operator is supported in your CI shell—or consider using a single=for broad compatibility.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/ci.yml(3 hunks)composer.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- composer.json
🔇 Additional comments (2)
.github/workflows/ci.yml (2)
59-61: Fallback to Composer UpdateThe fallback
composer update --prefer-dist --no-interaction --no-progressis a clear approach when thematrix.doctrine-ormcondition doesn’t match specific versions. Double-check that this behavior is intended for all other cases during the CI run.
83-83: Streamlined Coverage Upload Flag NamingChanging the flag name to
"PHP ${{ matrix.php }}"removes the now-unnecessary complexity of the previouscomposer-flagsreferences. This simplification aligns well with the overall goal of streamlining the CI configuration.
Summary by CodeRabbit
New Features
Tests