-
Notifications
You must be signed in to change notification settings - Fork 3.5k
docs: browser example for marked on page data #3864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@jhauga is attempting to deploy a commit to the MarkedJS Team on Vercel. A member of the Team first needs to authorize it. |
Summary of ChangesHello @jhauga, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new, clear example to the documentation, showcasing how to easily integrate the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new browser usage example to the documentation, which is a great idea. However, the proposed implementation for rendering on-page markdown has a flaw: it can lead to incorrect rendering or data loss if the markdown contains characters that resemble HTML tags. I've provided review comments with a suggested alternative using a <textarea> which is a safer and more robust pattern. I've also suggested a more accurate title for the example. These changes will help ensure the example is reliable and clear for users.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
UziTech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. I think this would be better in the Advanced Usage page below the Known Extensions. We have a couple other examples of marked usage there.
Marked version:
Markdown flavor:
https://cdn.jsdelivr.net/npm/marked/lib/marked.umd.jsDescription
This is a simple PR to the documentations. It proposes an additional example for usage in the browser. A
detailstag was used so the example can be toggled, as to not break the flow of the current documentation.The example shows how this tool could be used to render html elements as if markdown. See support-repo for an illustration of the example with markdown data. Click on the
index.htmllink to view the GitHub page. The essentials from the example were carried over to the exampleindex.htmlpage.Tested with
npm run build:docs. All was good. And for fun rannpm run test. All was good.Expectation
An additional example for browser use in the documentation.
Result
Someone first visiting the documentation will see how easy it is to use
markedon an html page, using inline page data and how to render it as if markdown.What was attempted
php -S localhostwith a test file with lots of data, and the elements from the proposed example. The rendered page was output as if markdown.Contributor
Committer
In most cases, this should be a different person than the contributor.