Work on control flow in try/catch (#222)

* Work on control flow in try/catch

* Improvements

* Refactor code

* Update diagnostic

* Introduce diagnostic

* Gray out catch block

* Fix unit tests

* Update CHANGELOG.md

Author: marinasundstrom

CHANGELOG.md

@@ -15,6 +15,7 @@ Adding improvements to the control flow analysis that was introduced in the last
 - [#212](https://github.com/marinasundstrom/CheckedExceptions/issues/212) Handle finally clause
 - [#217](https://github.com/marinasundstrom/CheckedExceptions/issues/217) Remove unused diagnostic
 - [#216](https://github.com/marinasundstrom/CheckedExceptions/issues/216) Assign categories to diagnostics
+- PR [#222](https://github.com/marinasundstrom/CheckedExceptions/pull/222) Work on control flow in try/catch
 
 ### Fixed
 

CheckedExceptions.Tests/CSharpAnalyzerVerifier.cs

@@ -63,6 +63,7 @@ await VerifyAnalyzerAsync(source, (test) =>
                 test.DisabledDiagnostics.Add(CheckedExceptionsAnalyzer.DiagnosticIdRedundantExceptionDeclaration);
                 //test.DisabledDiagnostics.Add(CheckedExceptionsAnalyzer.DiagnosticIdXmlDocButNoThrows);
                 test.DisabledDiagnostics.Add(CheckedExceptionsAnalyzer.DiagnosticIdRuleUnreachableCode);
+                test.DisabledDiagnostics.Add(CheckedExceptionsAnalyzer.DiagnosticIdRuleUnreachableCodeHidden);
 
                 test.DisabledDiagnostics.AddRange(allDiagnostics.Except(expected.Select(x => x.Id)));
             }
@@ -112,6 +113,7 @@ public static Task VerifyAnalyzerAsync([StringSyntax("c#-test")] string source,
         test.DisabledDiagnostics.Add(CheckedExceptionsAnalyzer.DiagnosticIdRedundantTypedCatchClause);
         test.DisabledDiagnostics.Add(CheckedExceptionsAnalyzer.DiagnosticIdRedundantExceptionDeclaration);
         test.DisabledDiagnostics.Add(CheckedExceptionsAnalyzer.DiagnosticIdRuleUnreachableCode);
+        test.DisabledDiagnostics.Add(CheckedExceptionsAnalyzer.DiagnosticIdRuleUnreachableCodeHidden);
 
         if (executable)
         {

CheckedExceptions/AnalyzerReleases.Unshipped.md

@@ -15,4 +15,5 @@ THROW010 | Contract | Error | CheckedExceptionsAnalyzer
 THROW011 | Contract | Warning | CheckedExceptionsAnalyzer
 THROW012 | Contract | Warning | CheckedExceptionsAnalyzer
 THROW013 | Control flow | Warning | CheckedExceptionsAnalyzer
-THROW020 | Control flow | Hidden | CheckedExceptionsAnalyzer
+THROW020 | Control flow | Warning | CheckedExceptionsAnalyzer
+IDE001 | Control flow | Hidden | CheckedExceptionsAnalyzer