Remove Roslyn Control flow analysis calls

Author: marinasundstrom

CheckedExceptions.Tests/TryCatchTest2.cs

@@ -343,16 +343,8 @@ static int ReadAndParse()
 
             try
             {
-                bool x = true;
-                if (x)
-                {
-                    //May throw FormatException, or OverflowException, or return
-                    return int.Parse(input);
-                }
-                else
-                {
-                    throw new InvalidCastException();
-                }         
+                //May throw FormatException, or OverflowException, or return
+                return int.Parse(input);    
             }
             catch (FormatException ex)
             {
@@ -372,19 +364,17 @@ static int ReadAndParse()
     }
     """;
 
-        /*
-            var expected = Verifier.Diagnostic(CheckedExceptionsAnalyzer.DiagnosticIdRedundantExceptionDeclaration)
-                .WithArguments("ArgumentException")
-                .WithSpan(11, 55, 11, 72);
+        var expected = Verifier.Diagnostic(CheckedExceptionsAnalyzer.DiagnosticIdRedundantExceptionDeclaration)
+            .WithArguments("ArgumentException")
+            .WithSpan(11, 55, 11, 72);
 
-            var expected2 = Verifier.Diagnostic(CheckedExceptionsAnalyzer.DiagnosticIdRedundantCatchAllClause)
-                .WithArguments("ArgumentException")
-                .WithSpan(32, 9, 32, 14);
-    */
+        var expected2 = Verifier.Diagnostic(CheckedExceptionsAnalyzer.DiagnosticIdRedundantCatchAllClause)
+            .WithArguments("ArgumentException")
+            .WithSpan(29, 9, 29, 14);
 
         await Verifier.VerifyAnalyzerAsync(test, o =>
         {
-            //o.ExpectedDiagnostics.AddRange(expected, expected2);
+            o.ExpectedDiagnostics.AddRange(expected, expected2);
 
             o.DisabledDiagnostics.Remove(CheckedExceptionsAnalyzer.DiagnosticIdRedundantExceptionDeclaration);
         });
@@ -436,17 +426,13 @@ static int ReadAndParse()
     }
     """;
 
-        var expected = Verifier.Diagnostic(CheckedExceptionsAnalyzer.DiagnosticIdRedundantExceptionDeclaration)
-            .WithArguments("InvalidUserInputException")
-            .WithSpan(11, 20, 11, 45);
-
-        var expected2 = Verifier.Diagnostic(CheckedExceptionsAnalyzer.DiagnosticIdRedundantCatchAllClause)
+        var expected = Verifier.Diagnostic(CheckedExceptionsAnalyzer.DiagnosticIdRedundantCatchAllClause)
             .WithArguments("ArgumentException")
             .WithSpan(33, 9, 33, 14);
 
         await Verifier.VerifyAnalyzerAsync(test, o =>
         {
-            o.ExpectedDiagnostics.AddRange(expected, expected2);
+            o.ExpectedDiagnostics.AddRange(expected);
 
             o.DisabledDiagnostics.Remove(CheckedExceptionsAnalyzer.DiagnosticIdRedundantExceptionDeclaration);
         });

CheckedExceptions/CheckedExceptionsAnalyzer.ControlFlow.cs

@@ -274,8 +274,8 @@ private FlowWithExceptionsResult AnalyzeBlockWithExceptions(
         {
             var flow = semanticModel.AnalyzeControlFlow(node);
 
-            if (!flow.Succeeded || !flow.StartPointIsReachable)
-                return FlowWithExceptionsResult.Unreachable;
+            //if (!flow.Succeeded || !flow.StartPointIsReachable)
+            //    return FlowWithExceptionsResult.Unreachable;
         }
 
         var unhandled = new HashSet<INamedTypeSymbol>(SymbolEqualityComparer.Default);
@@ -300,7 +300,7 @@ private FlowWithExceptionsResult AnalyzeBlockWithExceptions(
         {
             if (!reachable)
             {
-                var statementIndex = statements.TakeWhile(x => x != statement).Count();
+                var statementIndex = statements.TakeWhile(x => x != statement).Count() - 1;
 
                 // 🚩 We already know the block can’t continue past here
                 for (int i = statementIndex; i < statements.Count(); i++)
@@ -370,8 +370,8 @@ private FlowWithExceptionsResult AnalyzeStatementWithExceptions(
         // Control flow for this single statement
         var flow = semanticModel.AnalyzeControlFlow(statement);
 
-        if (!flow.Succeeded || !flow.StartPointIsReachable)
-            return FlowWithExceptionsResult.Unreachable;
+        //if (!flow.Succeeded || !flow.StartPointIsReachable)
+        //    return FlowWithExceptionsResult.Unreachable;
 
         // Handle nested blocks
         if (statement is BlockSyntax block)