Before validator #330
Open
Before validator #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test started failing with [1]. These annotations are somewhat of a duplicate of the constraints; one thought is that you could just parse out the first item of the Annotation - but that might cause more problems than it solves. Fix the testing so it works, but just skip this if somehow we have a lower sphinx to avoid bumping the base requirement. [1] sphinx-doc/sphinx@159c267
Currently this displays a BeforeValidator annotation as the str() (e.g. "<foo at 0x12345>") which is not helpful. Check if this validator is a function, and if so mark it with :py:func. Similarly, try to present something sane for the json_schema_input_type. A test-case is added Depends-On: mansenfranzen#329
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this displays a BeforeValidator annotation as the str() (e.g. "<foo at 0x12345>") which is not helpful. Check if this
validator is a function, and if so mark it with :py:func. Similarly, try to present something sane for the json_schema_input_type.
A test-case is added
Depends-On: #329
before:
after:
