Skip to content

Conversation

@Meltie2013
Copy link
Contributor

@Meltie2013 Meltie2013 commented Jul 25, 2025

Changes Made:

  • Updated the Linux Build file and removed some code/files from it
  • Added additional checks for Code Styling workflow to be a bit more aggressive with Functions and If Statement and how they are handled.
  • Added a manual script to use OpenSSL 3.5.1 [LTS] instead of OpenSSL 3.0.2 which is default in the latest version of Linux in the workflow environment.
  • Added tab character replacement, which will remove all tab character and replace them with 4 spaces per tab it finds.

New Tools;

  • Statement Spacing Fixer: This will fix spacing in between the statement and brace after it.
    Example:
    Incorrect:
    if(pointer)
    
    Correct:
    if (pointer)
    

Note:
With the Code Styling Check workflow, don't be surprised at what it spits out as I am still tweaking the regex out a bit more. The list is big just to say it.

More details will be added as I move along with the change/update.


This change is Reviewable

- Updated workflow for code styling
- Updated linux build file

For the code styling, I have added 6 new checks that will check code for a few things. Refer to the PR description area for more details.

Note: Making sure Linux is using the same version of OpenSSL as the Windows workflow build. So we are consistent with that package if problems happen. On the workflow side, default version is 3.0.2 from what I been seeing thus far.
@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

- Working on some exception patterns that will output but will be marked with 0 instead of 1. Still a working progress.
- Added general comments to the filters based on what they do.
@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

- Added in some code to replace tab spaces with 4 spaces per tab

Requested by @billy1arm
- Adding some paths ignore on some areas of the project, so only changes to the project source code will trigger a build and not areas like the ReadMe.md or apps folder.
@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

- This script needs review based on the rules used in the script.

Aggressive Level: Moderate-to-Strict
@AppVeyorBot
Copy link

- This script should be only touching the src folder and the contents within it.
@AppVeyorBot
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants