Organize workflow #185

Pysis868 · 2023-02-10T14:48:22Z

How palatable are these changes, if even relevant now?

This change is

Deduplicate and summarize workflow file.

AppVeyorBot · 2023-02-10T15:29:18Z

✅ Build Mangos ZERO Server 22.04.3-geinshog completed (commit 563c0bc81c by @Pysis868)

billy1arm · 2023-07-25T10:26:18Z

@Meltie2013 Does this look ok to you ?

AppVeyorBot · 2024-08-01T03:43:28Z

❌ Build Mangos ZERO Server 22.04.27-mblrayqx failed (commit 2d1b26ebb4 by @Pysis868)

apps/ci/ci-compile.sh

Meltie2013 · 2024-08-01T13:50:29Z

@billy1arm Once I see an updated workflow with the changes in play, will make the call.

AppVeyorBot · 2024-08-01T16:57:08Z

❌ Build Mangos ZERO Server 22.04.27-qskhrhtv failed (commit 5ee9b95c34 by @Pysis868)

Said up-to-date, not on a branch, had to `git pull origin master`.

AppVeyorBot · 2024-08-01T22:46:28Z

✅ Build Mangos ZERO Server 22.04.27-duasofcm completed (commit b67a0e510c by @Pysis868)

src/modules/Eluna

src/realmd

src/tools/Extractor_projects

dep

billy1arm

@Pysis868 can you revise this to the latest revision for the submodules ?

- dep - Eluna - realmd - Extractor_projects Strange each was in a detached HEAD state with a lot of changes / absent items. Cleaned those / discarded all changes, then pulled for each directly because of that problem not allowing easy looping from git. Already current: - SD3 - win

Pysis868 · 2024-08-28T19:29:50Z

As of a270f22, and an extra win master ref set/checkout and pull, which provided no additional changes after committing:

> git submodule
 c02243ee29630c0d3b51f69d49589332927c9c0e dep (heads/master)
 5ca638f99fcd4a9f2cc94b42d0443ffa010618d0 src/modules/Eluna (heads/master)
 519bbc302878681abf25685a4f0e7df5db560bc9 src/modules/SD3 (heads/master)
 e63d3a3bd9f36497909e8e040a00055f205e7063 src/realmd (heads/master)
 1d533d5fec24fce8237e81d863f8270330363303 src/tools/Extractor_projects (heads/master)
 8c5fdae01893ad16af975a3eeee02585692452ac win (heads/master)

AppVeyorBot · 2024-08-28T19:43:43Z

❌ Build Mangos ZERO Server 22.04.41-mcjvnxlf failed (commit c121c6d796 by @Pysis868)

For Eluna since it caused a `Hook.h` error.

to be consistent with master branch.

Pysis868 · 2024-08-28T22:01:36Z

Master was not using latest.
Thought this can all be solved with a merge, but I diffed and handled all manually now anyway:

git submodule status
 c02243ee29630c0d3b51f69d49589332927c9c0e dep (heads/master)
 058ffa1cb7f81bb111e3022d572a6311558c1d5f src/modules/Eluna (058ffa1)
 443cd7a5f701066cff624e3201f45de645f49cd2 src/modules/SD3 (heads/master-6-g443cd7a)
 e63d3a3bd9f36497909e8e040a00055f205e7063 src/realmd (heads/master)
 1d533d5fec24fce8237e81d863f8270330363303 src/tools/Extractor_projects (heads/master)
 8c5fdae01893ad16af975a3eeee02585692452ac win (heads/master)

AppVeyorBot · 2024-08-28T22:22:27Z

✅ Build Mangos ZERO Server 22.04.41-gelbtrml completed (commit 1c03c6e195 by @Pysis868)

AppVeyorBot · 2024-08-28T23:43:03Z

✅ Build Mangos ZERO Server 22.04.41-krqlpvpu completed (commit 80ca74ed0a by @Pysis868)

apps/ci/ci-compile.sh

Pysis868 · 2024-08-29T15:54:10Z

Run ./apps/ci/ci-packages.sh
  ./apps/ci/ci-packages.sh
  shell: /usr/bin/bash -e {0}
/home/runner/work/_temp/870baad1-32d8-40b1-9a44-fa551d09bc65.sh: line 1: ./apps/ci/ci-packages.sh: Permission denied
Error: Process completed with exit code 126.

apps/ci/ci-compiler-update.sh uses sudo, so thought it would be fine for this package script too. The workflow simply runs the scripts, and thought it was working before as well, since there was a build folder fix added.

Does added the source command prefix really make a difference?

.github/workflows/core_build.yml

Meltie2013

@Pysis868 Please check comment for details.

.github/workflows/core_windows_build.yml

Add `source` to package script invocation. Bring back commands for Windows build without script execution capability.

AppVeyorBot · 2024-08-30T05:35:24Z

✅ Build Mangos ZERO Server 22.04.49-xktxnvya completed (commit f5f3f94b3c by @Pysis868)

Pysis868

Reviewed 2 of 4 files at r1, 1 of 6 files at r2, 1 of 1 files at r3, 3 of 4 files at r5, 2 of 2 files at r6, 2 of 2 files at r7, all commit messages.
Reviewable status: all files reviewed, 8 unresolved discussions (waiting on @billy1arm and @Meltie2013)

.github/workflows/core_build.yml line 21 at r6 (raw file):

Previously, Meltie2013 wrote…

This should be:
run: source ./apps/ci/ci-packages.sh

Done.

Pysis868

Reviewable status: all files reviewed, 8 unresolved discussions (waiting on @billy1arm and @Meltie2013)

apps/ci/ci-compile.sh line 0 at r2 (raw file):

Previously, Meltie2013 wrote…

(Reviewable was unable to map this GitHub inline comment thread to the right spot — sorry!)

This should remain to see if the directory exists already or not.

Done.

src/realmd line 0 at r4 (raw file):

Previously, billy1arm (Antz) wrote…

@Pysis868 can you revise this to the latest revision

Done.

dep line 0 at r4 (raw file):

Previously, billy1arm (Antz) wrote…

@Pysis868 can you revise this to the latest revision

Done.

.github/workflows/core_windows_build.yml line 29 at r6 (raw file):

Previously, Meltie2013 wrote…

This line should be reverted back to how it was, since Shell files can not run in Windows directly.

Done.

src/modules/Eluna line 0 at r4 (raw file):

Previously, billy1arm (Antz) wrote…

@Pysis868 can you revise this to the latest revision

Done.

src/tools/Extractor_projects line 0 at r4 (raw file):

Previously, billy1arm (Antz) wrote…

@Pysis868 can you revise this to the latest revision

Done.

Pysis868

Reviewable status: all files reviewed, 8 unresolved discussions (waiting on @billy1arm and @Meltie2013)

Pysis868

Reviewable status: all files reviewed, 8 unresolved discussions (waiting on @billy1arm and @Meltie2013)

billy1arm

Reviewed 1 of 4 files at r1, 1 of 1 files at r3, 3 of 4 files at r5, 2 of 2 files at r6, 2 of 2 files at r7, all commit messages.
Reviewable status: all files reviewed, 8 unresolved discussions (waiting on @Meltie2013)

…workflow

AppVeyorBot · 2024-10-01T21:59:01Z

✅ Build Mangos ZERO Server 22.04.52-ybbkfcbx completed (commit 10a8589ccb by @Pysis868)

Organize workflow

8552e3e

Deduplicate and summarize workflow file.

Merge branch 'master' into feature/organize-workflow

ff8a942

Meltie2013 reviewed Aug 1, 2024

View reviewed changes

apps/ci/ci-compile.sh Show resolved Hide resolved

Make absent build directory

9f575f8

Manual Update SD3

5980cb2

Said up-to-date, not on a branch, had to `git pull origin master`.

Pysis868 requested a review from Meltie2013 August 2, 2024 17:17

billy1arm reviewed Aug 18, 2024

View reviewed changes

src/modules/Eluna Show resolved Hide resolved

billy1arm reviewed Aug 18, 2024

View reviewed changes

src/realmd Show resolved Hide resolved

billy1arm reviewed Aug 18, 2024

View reviewed changes

src/tools/Extractor_projects Show resolved Hide resolved

billy1arm reviewed Aug 18, 2024

View reviewed changes

dep Show resolved Hide resolved

billy1arm requested changes Aug 18, 2024

View reviewed changes

Pysis868 requested a review from billy1arm August 28, 2024 20:40

Pysis868 added 2 commits August 28, 2024 17:38

Reverting submodule update

5cfe168

For Eluna since it caused a `Hook.h` error.

Updates submodules

06d12e2

to be consistent with master branch.

billy1arm reviewed Aug 29, 2024

View reviewed changes

apps/ci/ci-compile.sh Show resolved Hide resolved

Pysis868 requested a review from billy1arm August 29, 2024 14:56

Meltie2013 reviewed Aug 30, 2024

View reviewed changes

.github/workflows/core_build.yml Outdated Show resolved Hide resolved

Meltie2013 suggested changes Aug 30, 2024

View reviewed changes

Meltie2013 reviewed Aug 30, 2024

View reviewed changes

.github/workflows/core_windows_build.yml Outdated Show resolved Hide resolved

Fix workflows

1b5888e

Add `source` to package script invocation. Bring back commands for Windows build without script execution capability.

Pysis868 requested a review from Meltie2013 August 30, 2024 04:49

Pysis868 commented Aug 30, 2024

View reviewed changes

Meltie2013 approved these changes Sep 1, 2024

View reviewed changes

Pysis868 commented Sep 20, 2024

View reviewed changes

billy1arm reviewed Oct 1, 2024

View reviewed changes

billy1arm approved these changes Oct 1, 2024

View reviewed changes

Pysis868 requested a review from Meltie2013 October 1, 2024 21:14

Merge remote-tracking branch 'upstream/master' into feature/organize-…

a239418

…workflow

Organize workflow #185

Are you sure you want to change the base?

Organize workflow #185

Uh oh!

Conversation

Pysis868 commented Feb 10, 2023 • edited by billy1arm Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AppVeyorBot commented Feb 10, 2023

Uh oh!

billy1arm commented Jul 25, 2023

Uh oh!

AppVeyorBot commented Aug 1, 2024

Uh oh!

Uh oh!

Meltie2013 commented Aug 1, 2024

Uh oh!

AppVeyorBot commented Aug 1, 2024

Uh oh!

AppVeyorBot commented Aug 1, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

billy1arm left a comment

Choose a reason for hiding this comment

Uh oh!

Pysis868 commented Aug 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AppVeyorBot commented Aug 28, 2024

Uh oh!

Pysis868 commented Aug 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AppVeyorBot commented Aug 28, 2024

Uh oh!

AppVeyorBot commented Aug 28, 2024

Uh oh!

Uh oh!

Pysis868 commented Aug 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Meltie2013 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AppVeyorBot commented Aug 30, 2024

Uh oh!

Pysis868 left a comment

Choose a reason for hiding this comment

Uh oh!

Pysis868 left a comment

Choose a reason for hiding this comment

Uh oh!

Pysis868 left a comment

Choose a reason for hiding this comment

Uh oh!

Pysis868 left a comment

Choose a reason for hiding this comment

Uh oh!

billy1arm left a comment

Choose a reason for hiding this comment

Uh oh!

AppVeyorBot commented Oct 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Pysis868 commented Feb 10, 2023 •

edited by billy1arm

Loading

Pysis868 commented Aug 28, 2024 •

edited

Loading

Pysis868 commented Aug 28, 2024 •

edited

Loading

Pysis868 commented Aug 29, 2024 •

edited

Loading