-
Notifications
You must be signed in to change notification settings - Fork 6
feat: add options field docs in create property API #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Create property API will now take `options` in the payload to create options in one call for OPTION type - Update type for setting custom property values with latest api changes
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughTwo API reference documentation files are updated with parameter modifications. The add-property endpoint gains an optional "options" parameter for OPTION-type properties, while the add-property-values endpoint restructures its "value" parameter to support multiple scalar types and multi-value handling. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
api-reference/issue-types/values/add-property-values.mdx (2)
32-32: Clarify multi-value UUID input flexibility.Line 32 indicates that multi-value OPTION/RELATION properties accept "list of strings (UUIDs) or single string," but the documentation doesn't explain how the API handles both formats. Specifically:
- When a single UUID string is sent for a multi-value property, does it create one record, or is behavior identical to passing
["uuid"]?- Are there edge cases where format matters (e.g., does sending a single string prevent multiple record creation that a list would enable)?
Clarify the expected behavior to avoid developer confusion about when to use single strings vs. arrays.
Suggested clarification:
- OPTION/RELATION (multi, when is_multi=True): list of strings (UUIDs) or single string + OPTION/RELATION (multi, when is_multi=True): list of strings (UUIDs) for multiple values, or single string (UUID) for a single valueAnd expand lines 34-35:
For multi-value properties (is_multi=True): - - Accept either a single UUID string or a list of UUID strings + - Accept either a single UUID string or a list of UUID strings. Single strings create one property value; lists create multiple records.Also applies to: 34-35
31-32: Consider specifying UUID format expectations.The documentation references UUIDs but doesn't specify the expected format (e.g., with hyphens, UUID v4). While this may be obvious from API responses, explicitly stating the format would help developers avoid format mismatches.
Example addition:
- OPTION/RELATION (single): string (UUID) - OPTION/RELATION (multi, when is_multi=True): list of strings (UUIDs) or single string + OPTION/RELATION (single): string (UUID in standard format, e.g., `550e8400-e29b-41d4-a716-446655440000`) + OPTION/RELATION (multi, when is_multi=True): list of strings (UUIDs) or single string
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
api-reference/issue-types/properties/add-property.mdx(1 hunks)api-reference/issue-types/values/add-property-values.mdx(1 hunks)
🔇 Additional comments (1)
api-reference/issue-types/properties/add-property.mdx (1)
36-46: Well-documented options parameter for OPTION-type property creation.The new
optionsparameter documentation is clear and comprehensive. It effectively explains how developers can set options during property creation rather than requiring a separate API call. The field descriptions and reference to the post-creation API endpoint are helpful.
Description
optionsin the payload to create options in one call for OPTION typeType of Change
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.