arch: add linux-based LVGL supported boards #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="boards/renesas/rz-g3e-evkit/README.md">
<violation number="1" location="boards/renesas/rz-g3e-evkit/README.md:117">
The sample CMake command selects `-DCONFIG=drm-egl`, but the repo only ships `drm-egl-2d.defaults`, so following these instructions fails to configure the build. Please update the command to use the available `drm-egl-2d` config.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
AndreCostaaa
force-pushed
the
docs-add-supported-boards
branch
2 times, most recently
from
5068d43 to
539ac2e
Compare
There was a problem hiding this comment.
11 issues found across 20 files (changes from recent commits).
Prompt for AI agents (all 11 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="boards/toradex-verdin_imx8m_mini/manifest.json">
<violation number="1" location="boards/toradex-verdin_imx8m_mini/manifest.json:36">
P3: Typo in `getStartedInstructions`: "Follw" should be "Follow".</violation>
</file>
<file name="boards/toradex-verdin_am62/README.md">
<violation number="1" location="boards/toradex-verdin_am62/README.md:108">
P3: Typo: 'lastest' should be 'latest'.</violation>
<violation number="2" location="boards/toradex-verdin_am62/README.md:142">
P2: Broken URL: The link starts with `/https://` which is invalid. Remove the leading `/` to fix the URL.</violation>
</file>
<file name="boards/f-and-s_picocoremx93/README.md">
<violation number="1" location="boards/f-and-s_picocoremx93/README.md:82">
P3: Typo: 'kti' should be 'kit'.</violation>
<violation number="2" location="boards/f-and-s_picocoremx93/README.md:97">
P3: Grammar error: 'where were' should be 'which were' or 'that were'.</violation>
</file>
<file name="boards/toradex-verdin_am62/manifest.json">
<violation number="1" location="boards/toradex-verdin_am62/manifest.json:36">
P2: Typo: "Follw" should be "Follow" in the instructions.</violation>
</file>
<file name="boards/texas-instruments_sk-am62b-p1/README.md">
<violation number="1" location="boards/texas-instruments_sk-am62b-p1/README.md:225">
P2: Incorrect grep pattern for TI board. `verdin-am62` is a Toradex board hostname, but this README is for Texas Instruments SK-AM62B-P1. The original `am62xx` pattern was correct for TI boards. Users following this guide will not find their TI board using this grep pattern.</violation>
</file>
<file name="boards/toradex-verdin_imx8m_mini/README.md">
<violation number="1" location="boards/toradex-verdin_imx8m_mini/README.md:128">
P3: Typo: "lastest" should be "latest".</violation>
<violation number="2" location="boards/toradex-verdin_imx8m_mini/README.md:162">
P2: Malformed URL: `/https://` should be `https://`. The leading slash makes this a broken relative path instead of an external link.</violation>
</file>
<file name="boards/texas-instruments_sk-am62p-lp/README.md">
<violation number="1" location="boards/texas-instruments_sk-am62p-lp/README.md:220">
P1: The nmap grep pattern `verdin-am62` is incorrect for the Texas Instruments SK-AM62P-LP board. This pattern is specific to Toradex Verdin AM62 boards. The original pattern `am62pxx` was correct for this Texas Instruments board and should be retained.</violation>
</file>
<file name="boards/nxp_imx93/README.md">
<violation number="1" location="boards/nxp_imx93/README.md:311">
P1: Incorrect hostname pattern in nmap grep. This README is for NXP i.MX93 EVK but the grep pattern `verdin-am62` is for Toradex Verdin boards. Should be `imx93-11x11-lpddr4x-evk` to match the i.MX93 hostname.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
There was a problem hiding this comment.
6 issues found across 17 files (changes from recent commits).
Prompt for AI agents (all 6 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="boards/toradex-verdin_imx8m_mini/README.md">
<violation number="1" location="boards/toradex-verdin_imx8m_mini/README.md:11">
P2: Incorrect Markdown image syntax - the path should not be wrapped in quotes. This will cause the image to fail to render.</violation>
</file>
<file name="boards/texas-instruments_sk-am62p-lp/manifest.json">
<violation number="1" location="boards/texas-instruments_sk-am62p-lp/manifest.json:26">
P1: Malformed GitHub URL in `getStartedInstructions`. The path `lv_port_linux/lv_port_texas_sk-am62p-lp/blob/master` is invalid GitHub URL syntax and will result in a 404. Based on the pattern used in other board manifests (e.g., `nxp_imx93`), the URL should follow the format `/tree/master/boards/<board-name>/README.md`.</violation>
</file>
<file name="boards/toradex-verdin_am62/README.md">
<violation number="1" location="boards/toradex-verdin_am62/README.md:12">
P2: Invalid Markdown image syntax. The quotes around the path will cause the image to fail loading. Remove the quotes from the image URL.</violation>
</file>
<file name="boards/nxp_imx93/README.md">
<violation number="1" location="boards/nxp_imx93/README.md:300">
P2: Missing closing code fence (` ``` `) after `ip a`. This will break markdown rendering and cause subsequent content to appear inside the code block.</violation>
</file>
<file name="boards/toradex-verdin_imx8m_mini/manifest.json">
<violation number="1" location="boards/toradex-verdin_imx8m_mini/manifest.json:29">
P2: The `getStartedInstructions` links to the old repository's README (`lv_port_toradex_verdin_imx8m_mini`) while `urlToClone` now points to `lv_port_linux.git`. This mismatch may confuse users. Consider updating the README link to point to the local board README or the `lv_port_linux` repository's README.</violation>
</file>
<file name="boards/toradex-verdin_am62/manifest.json">
<violation number="1" location="boards/toradex-verdin_am62/manifest.json:29">
P2: The `getStartedInstructions` URL is inconsistent with the new `urlToClone`. Since `urlToClone` was changed to `lv_port_linux.git`, the README link should point to the corresponding path in that repository, not the old `lv_port_toradex_verdin_am62` repository (which users won't have cloned).</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
Collaborator
Author
|
@cubic-dev-ai review this |
@AndreCostaaa I've started the AI code review. It'll take a few minutes to complete. |
There was a problem hiding this comment.
17 issues found across 30 files
Prompt for AI agents (all 17 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="boards/texas-instruments_sk-am62l/README.md">
<violation number="1" location="boards/texas-instruments_sk-am62l/README.md:112">
P2: Duplicate '### Software setup' section. The document contains two nearly identical 'Software setup' sections - one for Ubuntu 20.04 (line 99) and one for Ubuntu 22.04 (line 117). This appears to be accidental duplication. Consider consolidating into a single section, keeping the first one which has links for both Ubuntu versions.</violation>
</file>
<file name="boards/texas-instruments_sk-am62p-lp/README.md">
<violation number="1" location="boards/texas-instruments_sk-am62p-lp/README.md:7">
P3: Missing preposition: "to run it the target" should be "to run it on the target".</violation>
<violation number="2" location="boards/texas-instruments_sk-am62p-lp/README.md:86">
P2: Typo: "EEC" should be "ECC" (Error Correcting Code). The manifest.json for this board correctly uses "ECC".</violation>
</file>
<file name="boards/texas-instruments_sk-am62b-p1/README.md">
<violation number="1" location="boards/texas-instruments_sk-am62b-p1/README.md:8">
P3: Typo: Missing word "on" - should be "to run it on the target" instead of "to run it the target".</violation>
<violation number="2" location="boards/texas-instruments_sk-am62b-p1/README.md:88">
P2: Typo: "EEC" should be "ECC" (Error-Correcting Code). The manifest.json file for this board correctly uses "ECC".</violation>
</file>
<file name="boards/renesas_rz-g3e-evkit/README.md">
<violation number="1" location="boards/renesas_rz-g3e-evkit/README.md:115">
P2: Incomplete sentence: 'Select it by running' is cut off and merged with the next sentence. The SDK note should be on a separate line, and 'Select it by running:' should end with a colon before the code block.</violation>
</file>
<file name="boards/toradex-verdin_am62/README.md">
<violation number="1" location="boards/toradex-verdin_am62/README.md:32">
P2: Incorrect URL for Yavia carrier board. The link text says "Yavia" but the URL points to `verdin-development-board`, which is the same URL used for the Verdin Development Board link below. This appears to be a copy-paste error.</violation>
<violation number="2" location="boards/toradex-verdin_am62/README.md:316">
P2: Inconsistent build folder name. The build commands use `-B build` which creates a `build` folder, but the troubleshooting section references `build-arm64`. This should be `build` to match the earlier instructions.</violation>
</file>
<file name="boards/nxp_imx93/README.md">
<violation number="1" location="boards/nxp_imx93/README.md:8">
P3: Grammar error: 'to run it the target' should be 'to run it on the target'.</violation>
<violation number="2" location="boards/nxp_imx93/README.md:126">
P3: Typo: 'pannel' should be 'panel'.</violation>
<violation number="3" location="boards/nxp_imx93/README.md:145">
P2: Incomplete sentence: 'Connect the screen to the' is missing the object (e.g., 'LVDS connector', 'display port').</violation>
<violation number="4" location="boards/nxp_imx93/README.md:221">
P3: Typo: 'environnement' should be 'environment'.</violation>
</file>
<file name="boards/f-and-s_picocoremx93/README.md">
<violation number="1" location="boards/f-and-s_picocoremx93/README.md:162">
P3: Missing closing quote: `"root.` should be `"root".`</violation>
<violation number="2" location="boards/f-and-s_picocoremx93/README.md:228">
P2: Recommending `rm ~/.ssh/known_hosts` is overly destructive and removes security protections for all hosts. Use `ssh-keygen -R <ip_address>` to remove only the specific problematic entry.</violation>
</file>
<file name="boards/toradex-verdin_imx8m-mini/README.md">
<violation number="1" location="boards/toradex-verdin_imx8m-mini/README.md:30">
P2: Yavia link appears to be incorrect - it points to the Verdin Development Board URL instead of the Yavia-specific documentation. Both Yavia and Verdin Development Board have the same URL, which is likely a copy-paste error.</violation>
<violation number="2" location="boards/toradex-verdin_imx8m-mini/README.md:337">
P2: Inconsistent build directory name: The cmake command creates a `build` directory, but this troubleshooting command references `build-arm64`. Should be `rm -rf lv_port_linux/build` to match the actual build path.</violation>
</file>
<file name="boards/texas-instruments_sk-am62l/manifest.json">
<violation number="1" location="boards/texas-instruments_sk-am62l/manifest.json:25">
P2: The README link is missing the `boards/` directory prefix. This will result in a 404 error when users click the link. Other board manifests correctly use `master/boards/<board-name>/README.md`.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
| Coming soon. | ||
|
|
||
|
|
||
| ### Software setup |
There was a problem hiding this comment.
P2: Duplicate '### Software setup' section. The document contains two nearly identical 'Software setup' sections - one for Ubuntu 20.04 (line 99) and one for Ubuntu 22.04 (line 117). This appears to be accidental duplication. Consider consolidating into a single section, keeping the first one which has links for both Ubuntu versions.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At boards/texas-instruments_sk-am62l/README.md, line 112:
<comment>Duplicate '### Software setup' section. The document contains two nearly identical 'Software setup' sections - one for Ubuntu 20.04 (line 99) and one for Ubuntu 22.04 (line 117). This appears to be accidental duplication. Consider consolidating into a single section, keeping the first one which has links for both Ubuntu versions.</comment>
<file context>
@@ -0,0 +1,317 @@
+Coming soon.
+
+
+### Software setup
+
+This guide was tested on Ubuntu 20.04 host.
</file context>
✅ Addressed in 80a4bc8
|
|
||
| ## Overview | ||
|
|
||
| This guide provides steps to setup the SK-AM62P-LP starter kit and to cross-compile an LVGL application to run it the target. |
There was a problem hiding this comment.
P3: Missing preposition: "to run it the target" should be "to run it on the target".
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At boards/texas-instruments_sk-am62p-lp/README.md, line 7:
<comment>Missing preposition: "to run it the target" should be "to run it on the target".</comment>
<file context>
@@ -0,0 +1,319 @@
+
+## Overview
+
+This guide provides steps to setup the SK-AM62P-LP starter kit and to cross-compile an LVGL application to run it the target.
+
+## Buy
</file context>
Suggested change
| This guide provides steps to setup the SK-AM62P-LP starter kit and to cross-compile an LVGL application to run it the target. | |
| This guide provides steps to setup the SK-AM62P-LP starter kit and to cross-compile an LVGL application to run it on the target. |
✅ Addressed in 80a4bc8
| - **MCU**: AM625P with Quad 64-bit Arm Cortex-A53 up to 1.4GHz, two ARM Cortex R5F single core up to 800MHz | ||
| - **RAM**: 8GB LPDDR4 | ||
|
|
||
| - 32-bits data bus with inline EEC |
There was a problem hiding this comment.
P2: Typo: "EEC" should be "ECC" (Error Correcting Code). The manifest.json for this board correctly uses "ECC".
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At boards/texas-instruments_sk-am62p-lp/README.md, line 86:
<comment>Typo: "EEC" should be "ECC" (Error Correcting Code). The manifest.json for this board correctly uses "ECC".</comment>
<file context>
@@ -0,0 +1,319 @@
+- **MCU**: AM625P with Quad 64-bit Arm Cortex-A53 up to 1.4GHz, two ARM Cortex R5F single core up to 800MHz
+- **RAM**: 8GB LPDDR4
+
+ - 32-bits data bus with inline EEC
+ - Supports speeds up to 3200 MT/s
+
</file context>
Suggested change
| - 32-bits data bus with inline EEC | |
| - 32-bits data bus with inline ECC |
✅ Addressed in 80a4bc8
|
|
||
| ## Overview | ||
|
|
||
| This guide provides steps to setup the SK-AM62B-P1 and to cross-compile an LVGL application to run it the target. |
There was a problem hiding this comment.
P3: Typo: Missing word "on" - should be "to run it on the target" instead of "to run it the target".
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At boards/texas-instruments_sk-am62b-p1/README.md, line 8:
<comment>Typo: Missing word "on" - should be "to run it on the target" instead of "to run it the target".</comment>
<file context>
@@ -0,0 +1,322 @@
+
+## Overview
+
+This guide provides steps to setup the SK-AM62B-P1 and to cross-compile an LVGL application to run it the target.
+
+## Buy
</file context>
Suggested change
| This guide provides steps to setup the SK-AM62B-P1 and to cross-compile an LVGL application to run it the target. | |
| This guide provides steps to setup the SK-AM62B-P1 and to cross-compile an LVGL application to run it on the target. |
✅ Addressed in 80a4bc8
|
|
||
| - **RAM**: 2GB DDR4 | ||
|
|
||
| - 16-bits data bus with inline EEC |
There was a problem hiding this comment.
P2: Typo: "EEC" should be "ECC" (Error-Correcting Code). The manifest.json file for this board correctly uses "ECC".
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At boards/texas-instruments_sk-am62b-p1/README.md, line 88:
<comment>Typo: "EEC" should be "ECC" (Error-Correcting Code). The manifest.json file for this board correctly uses "ECC".</comment>
<file context>
@@ -0,0 +1,322 @@
+
+- **RAM**: 2GB DDR4
+
+ - 16-bits data bus with inline EEC
+ - Supports speeds up to 1600 MT/s
+
</file context>
Suggested change
| - 16-bits data bus with inline EEC | |
| - 16-bits data bus with inline ECC |
✅ Addressed in 80a4bc8
| ends to enter the U-Boot prompt. | ||
| 4. At the `u-boot=>` prompt, enter the command `ums 0 mmc 0`. | ||
| 5. Find the block device exported by the board on your PC (likely staring with `/dev/sd*`). It will likely show two | ||
| existing partitions: "boot" and "root. Unmount both so that the block device has |
There was a problem hiding this comment.
P3: Missing closing quote: "root. should be "root".
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At boards/f-and-s_picocoremx93/README.md, line 162:
<comment>Missing closing quote: `"root.` should be `"root".`</comment>
<file context>
@@ -0,0 +1,252 @@
+ ends to enter the U-Boot prompt.
+4. At the `u-boot=>` prompt, enter the command `ums 0 mmc 0`.
+5. Find the block device exported by the board on your PC (likely staring with `/dev/sd*`). It will likely show two
+ existing partitions: "boot" and "root. Unmount both so that the block device has
+ no mounted partitions.
+6. Use Etcher or any other method like `dd` (which can take longer) to write the built
</file context>
Suggested change
| existing partitions: "boot" and "root. Unmount both so that the block device has | |
| existing partitions: "boot" and "root". Unmount both so that the block device has |
✅ Addressed in 80a4bc8
|
|
||
| If you cannot proceed during deploy/launch/debug due to | ||
| `WARNING: REMOTE HOST IDENTIFICATION HAS CHANGED!`, one solution is to delete `~/.ssh/known_hosts`. | ||
| I.e., `rm ~/.ssh/known_hosts`. |
There was a problem hiding this comment.
P2: Recommending rm ~/.ssh/known_hosts is overly destructive and removes security protections for all hosts. Use ssh-keygen -R <ip_address> to remove only the specific problematic entry.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At boards/f-and-s_picocoremx93/README.md, line 228:
<comment>Recommending `rm ~/.ssh/known_hosts` is overly destructive and removes security protections for all hosts. Use `ssh-keygen -R <ip_address>` to remove only the specific problematic entry.</comment>
<file context>
@@ -0,0 +1,252 @@
+
+If you cannot proceed during deploy/launch/debug due to
+`WARNING: REMOTE HOST IDENTIFICATION HAS CHANGED!`, one solution is to delete `~/.ssh/known_hosts`.
+I.e., `rm ~/.ssh/known_hosts`.
+
+There is also a pre-built `lvglsim` binary in the release artifacts of this repo on GitHub. You
</file context>
Suggested change
| I.e., `rm ~/.ssh/known_hosts`. | |
| I.e., `ssh-keygen -R <board_ip_address>`. |
✅ Addressed in 80a4bc8
| This is a SoM (System on Module) that can be tested with a carrier board. Toradex recommends ordering one of the following carrier boards for your first-time order: | ||
|
|
||
| - [Dahlia Carrier Board](https://developer.toradex.com/hardware/verdin-som-family/carrier-boards/dahlia-carrier-board/) | ||
| - [Yavia](https://developer.toradex.com/hardware/verdin-som-family/carrier-boards/verdin-development-board/) |
There was a problem hiding this comment.
P2: Yavia link appears to be incorrect - it points to the Verdin Development Board URL instead of the Yavia-specific documentation. Both Yavia and Verdin Development Board have the same URL, which is likely a copy-paste error.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At boards/toradex-verdin_imx8m-mini/README.md, line 30:
<comment>Yavia link appears to be incorrect - it points to the Verdin Development Board URL instead of the Yavia-specific documentation. Both Yavia and Verdin Development Board have the same URL, which is likely a copy-paste error.</comment>
<file context>
@@ -0,0 +1,345 @@
+This is a SoM (System on Module) that can be tested with a carrier board. Toradex recommends ordering one of the following carrier boards for your first-time order:
+
+- [Dahlia Carrier Board](https://developer.toradex.com/hardware/verdin-som-family/carrier-boards/dahlia-carrier-board/)
+- [Yavia](https://developer.toradex.com/hardware/verdin-som-family/carrier-boards/verdin-development-board/)
+- [Verdin Development Board](https://developer.toradex.com/hardware/verdin-som-family/carrier-boards/verdin-development-board/)
+
</file context>
✅ Addressed in 80a4bc8
| CMake may have troubles with CMakeLists.txt changes with some variables setup. If there is any problem building, try to clean the build folder: | ||
|
|
||
| ```bash | ||
| rm -rf lv_port_linux/build-arm64 |
There was a problem hiding this comment.
P2: Inconsistent build directory name: The cmake command creates a build directory, but this troubleshooting command references build-arm64. Should be rm -rf lv_port_linux/build to match the actual build path.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At boards/toradex-verdin_imx8m-mini/README.md, line 337:
<comment>Inconsistent build directory name: The cmake command creates a `build` directory, but this troubleshooting command references `build-arm64`. Should be `rm -rf lv_port_linux/build` to match the actual build path.</comment>
<file context>
@@ -0,0 +1,345 @@
+CMake may have troubles with CMakeLists.txt changes with some variables setup. If there is any problem building, try to clean the build folder:
+
+```bash
+rm -rf lv_port_linux/build-arm64
+```
+
</file context>
Suggested change
| rm -rf lv_port_linux/build-arm64 | |
| rm -rf lv_port_linux/build |
✅ Addressed in 80a4bc8
| "image": "https://raw.githubusercontent.com/lvgl/lv_port_linux/master/boards/texas-instruments_sk-am62l/ti-sk-am62l.webp", | ||
| "buy_now_links": ["https://www.ti.com/tool/TMDS62LEVM"], | ||
| "branches": ["release/v9.2"], | ||
| "getStartedInstructions": "1. Open the project folder and update the submodules: `git submodule update --init --recursive` \n2. Follow the guide in the [README](https://github.com/lvgl/lv_port_linux/blob/master/texas-instruments_sk-am62l/README.md#getting-started)", |
There was a problem hiding this comment.
P2: The README link is missing the boards/ directory prefix. This will result in a 404 error when users click the link. Other board manifests correctly use master/boards/<board-name>/README.md.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At boards/texas-instruments_sk-am62l/manifest.json, line 25:
<comment>The README link is missing the `boards/` directory prefix. This will result in a 404 error when users click the link. Other board manifests correctly use `master/boards/<board-name>/README.md`.</comment>
<file context>
@@ -0,0 +1,27 @@
+ "image": "https://raw.githubusercontent.com/lvgl/lv_port_linux/master/boards/texas-instruments_sk-am62l/ti-sk-am62l.webp",
+ "buy_now_links": ["https://www.ti.com/tool/TMDS62LEVM"],
+ "branches": ["release/v9.2"],
+ "getStartedInstructions": "1. Open the project folder and update the submodules: `git submodule update --init --recursive` \n2. Follow the guide in the [README](https://github.com/lvgl/lv_port_linux/blob/master/texas-instruments_sk-am62l/README.md#getting-started)",
+ "settings": []
+}
</file context>
Suggested change
| "getStartedInstructions": "1. Open the project folder and update the submodules: `git submodule update --init --recursive` \n2. Follow the guide in the [README](https://github.com/lvgl/lv_port_linux/blob/master/texas-instruments_sk-am62l/README.md#getting-started)", | |
| "getStartedInstructions": "1. Open the project folder and update the submodules: `git submodule update --init --recursive` \n2. Follow the guide in the [README](https://github.com/lvgl/lv_port_linux/tree/master/boards/texas-instruments_sk-am62l/README.md#getting-started)", |
✅ Addressed in 80a4bc8
Collaborator
Author
|
@cubic-dev-ai review this |
@AndreCostaaa Sorry, I encountered an error while trying to start the review. Please try again later. |
There was a problem hiding this comment.
3 issues found across 31 files
Prompt for AI agents (all 3 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="boards/texas-instruments_sk-am62l/README.md">
<violation number="1" location="boards/texas-instruments_sk-am62l/README.md:80">
P2: Incorrect MCU specification: The README for the SK-AM62L (TMDS62LEVM) board incorrectly states the MCU is 'AM625' but this board uses an AM62Lx processor. This appears to be copied from another board's documentation.</violation>
</file>
<file name="boards/nxp_imx93/README.md">
<violation number="1" location="boards/nxp_imx93/README.md:201">
P1: Using hardcoded `/dev/sda` is dangerous as it could accidentally overwrite the user's primary system drive. Use a placeholder like `/dev/sdX` with a comment instructing users to verify the correct device, consistent with other board READMEs in this PR.</violation>
</file>
<file name="boards/texas-instruments_sk-am62b-p1/README.md">
<violation number="1" location="boards/texas-instruments_sk-am62b-p1/README.md:231">
P2: Incorrect path to executable. The cmake builds to `build/bin/lvglsim`, but this scp command is missing the `build/` directory. If running from parent directory, use `lv_port_linux/build/bin/lvglsim`; if inside lv_port_linux, use `build/bin/lvglsim`.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
|
|
||
| - **MCU**: | ||
|
|
||
| - AM625 with Dual 64-bit Arm Cortex-A53 up to 1.25GHz |
There was a problem hiding this comment.
P2: Incorrect MCU specification: The README for the SK-AM62L (TMDS62LEVM) board incorrectly states the MCU is 'AM625' but this board uses an AM62Lx processor. This appears to be copied from another board's documentation.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At boards/texas-instruments_sk-am62l/README.md, line 80:
<comment>Incorrect MCU specification: The README for the SK-AM62L (TMDS62LEVM) board incorrectly states the MCU is 'AM625' but this board uses an AM62Lx processor. This appears to be copied from another board's documentation.</comment>
<file context>
@@ -0,0 +1,295 @@
+
+- **MCU**:
+
+ - AM625 with Dual 64-bit Arm Cortex-A53 up to 1.25GHz
+
+- **RAM**: 2GB DDR4
</file context>
Suggested change
| - AM625 with Dual 64-bit Arm Cortex-A53 up to 1.25GHz | |
| - AM62Lx with Dual 64-bit Arm Cortex-A53 up to 1.25GHz |
✅ Addressed in c65a9c7
boards/nxp_imx93/README.md
Outdated
| After downloading or building the image, flash it on the SD card: | ||
|
|
||
| ```bash | ||
| zstdcat imx-image-multimedia-imx93-11x11-lpddr4x-evk.rootfs-20240918104911.wic.zst | sudo dd of=/dev/sda bs=1M conv=fsync status=progress |
There was a problem hiding this comment.
P1: Using hardcoded /dev/sda is dangerous as it could accidentally overwrite the user's primary system drive. Use a placeholder like /dev/sdX with a comment instructing users to verify the correct device, consistent with other board READMEs in this PR.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At boards/nxp_imx93/README.md, line 201:
<comment>Using hardcoded `/dev/sda` is dangerous as it could accidentally overwrite the user's primary system drive. Use a placeholder like `/dev/sdX` with a comment instructing users to verify the correct device, consistent with other board READMEs in this PR.</comment>
<file context>
@@ -0,0 +1,395 @@
+After downloading or building the image, flash it on the SD card:
+
+```bash
+zstdcat imx-image-multimedia-imx93-11x11-lpddr4x-evk.rootfs-20240918104911.wic.zst | sudo dd of=/dev/sda bs=1M conv=fsync status=progress
+```
+
</file context>
Suggested change
| zstdcat imx-image-multimedia-imx93-11x11-lpddr4x-evk.rootfs-20240918104911.wic.zst | sudo dd of=/dev/sda bs=1M conv=fsync status=progress | |
| # Replace /dev/sdX with the correct device (e.g., /dev/sdb). Use 'lsblk' to identify your SD card. | |
| zstdcat imx-image-multimedia-imx93-11x11-lpddr4x-evk.rootfs-20240918104911.wic.zst | sudo dd of=/dev/sdX bs=1M conv=fsync status=progress |
✅ Addressed in c65a9c7
| - Then transfer the executable on the board: | ||
|
|
||
| ```bash | ||
| scp lv_port_linux/bin/lvglsim root@<BOARD_IP>:/root |
There was a problem hiding this comment.
P2: Incorrect path to executable. The cmake builds to build/bin/lvglsim, but this scp command is missing the build/ directory. If running from parent directory, use lv_port_linux/build/bin/lvglsim; if inside lv_port_linux, use build/bin/lvglsim.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At boards/texas-instruments_sk-am62b-p1/README.md, line 231:
<comment>Incorrect path to executable. The cmake builds to `build/bin/lvglsim`, but this scp command is missing the `build/` directory. If running from parent directory, use `lv_port_linux/build/bin/lvglsim`; if inside lv_port_linux, use `build/bin/lvglsim`.</comment>
<file context>
@@ -0,0 +1,322 @@
+- Then transfer the executable on the board:
+
+ ```bash
+ scp lv_port_linux/bin/lvglsim root@<BOARD_IP>:/root
+ ```
+
</file context>
Suggested change
| scp lv_port_linux/bin/lvglsim root@<BOARD_IP>:/root | |
| scp lv_port_linux/build/bin/lvglsim root@<BOARD_IP>:/root |
✅ Addressed in c65a9c7
AndreCostaaa
changed the title
AndreCostaaa
force-pushed
the
docs-add-supported-boards
branch
from
9cdb61e to
bae7278
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Added docs and manifests for eight Linux boards, with setup, build/run, debugging, and benchmark guides to make getting started easier. Also added a cross-compilation Dockerfile and VS Code configs for streamlined development.
New Features
Refactors
Written for commit bae7278. Summary will update automatically on new commits.