Skip to content

Conversation

@lucassouzavieira
Copy link
Owner

Add better validation for 'keyOptions' property for collections

@lucassouzavieira lucassouzavieira self-assigned this Oct 5, 2025
@lucassouzavieira lucassouzavieira added the feature/enhancement Request for a new feature or an enhancement label Oct 5, 2025
@lucassouzavieira lucassouzavieira changed the base branch from main to develop October 5, 2025 02:49
* @throws GuzzleException|InvalidParameterException|CursorException
*/
public function all()
public function all(): bool|CollectionCursor

Check warning

Code scanning / Phpcs (reported by Codacy)

Expected at least 1 space before "|"; 0 found Warning

Expected at least 1 space before "|"; 0 found
* @throws GuzzleException|InvalidParameterException|CursorException
*/
public function all()
public function all(): bool|CollectionCursor

Check warning

Code scanning / Phpcs (reported by Codacy)

Expected at least 1 space after "|"; 0 found Warning

Expected at least 1 space after "|"; 0 found
*/
class KeyType
{
public const string TRADITIONAL = 'traditional';

Check warning

Code scanning / Phpcs (reported by Codacy)

Class constants must be uppercase; expected STRING but found string Warning

Class constants must be uppercase; expected STRING but found string
class KeyType
{
public const string TRADITIONAL = 'traditional';
public const string AUTOINCREMENT = 'autoincrement';

Check warning

Code scanning / Phpcs (reported by Codacy)

Class constants must be uppercase; expected STRING but found string Warning

Class constants must be uppercase; expected STRING but found string
{
public const string TRADITIONAL = 'traditional';
public const string AUTOINCREMENT = 'autoincrement';
public const string PADDED = 'padded';

Check warning

Code scanning / Phpcs (reported by Codacy)

Class constants must be uppercase; expected STRING but found string Warning

Class constants must be uppercase; expected STRING but found string
public const string TRADITIONAL = 'traditional';
public const string AUTOINCREMENT = 'autoincrement';
public const string PADDED = 'padded';
public const string UUID = 'uuid';

Check warning

Code scanning / Phpcs (reported by Codacy)

Class constants must be uppercase; expected STRING but found string Warning

Class constants must be uppercase; expected STRING but found string
* @var string|int
*/
protected $parameter;
protected string|int $parameter;

Check warning

Code scanning / Phpcs (reported by Codacy)

Expected at least 1 space before "|"; 0 found Warning

Expected at least 1 space before "|"; 0 found
* @var string|int
*/
protected $parameter;
protected string|int $parameter;

Check warning

Code scanning / Phpcs (reported by Codacy)

Expected at least 1 space after "|"; 0 found Warning

Expected at least 1 space after "|"; 0 found
@lucassouzavieira lucassouzavieira merged commit 7cbddbc into develop Oct 5, 2025
10 checks passed
lucassouzavieira added a commit that referenced this pull request Oct 11, 2025
* fix: use 'sprintf' instead of string interpolation

* drop tests for arango 3.11 and add tests with PHP 8.4

* Update php.yml

* Update dependencies

* composer update + composer bump

* Small refactor on AQL namespace

* update .gitignore

* fix code sniffs

* Http namespace refactor

* update dev dependencies

* refactor: ODM tests

* refactor: PSR12 code fix for tests

* refactor: PSR12 code fix for src/

* chore: remove obsolete collection properties (#14)

* Improved validation for collection key options (#15)

* improve Collection 'keyOptions' attribute validation

* refactor 'KeyType' class

* fix exception attribute type

* drop support for PHP 8.2

* remove uses of 'print_r' (#16)

* Drop noop method 'load' for Collections (#17)

* small refactors for Cursor namespace

* drop no-op collection method 'load'

* refactor AQLFunction exception handling

* small refactors for AQL namespace

* remove unused exception'

* remove unused variables

* small refactor on Graph namespace

* refactors on Transaction namespace

* one more round of small fixes

* refactor array list

* add make file with test, lint and static analyzer helpers

* chore[PHP-8.4]: Handle php 8.4 deprecations (#18)

* chore[php-8.4]: handle php 8.4 deprecations

* chore[php-8.4]: revert enforcing strict type on 'Admin\Task\Task::'

* feat[index]: Add support for inverted indexes (#19)

* feat[inverted-index]: strict typing for base index class

* chore[indexes]: deprecate 'hash' and 'skiplist' index types

* feat[indexes]: base implementation for 'inverted' index

* tests[indexes]: remove ununsed imports

* tests[indexes]: add tests for inverted index

* feat[indexes]: add inverted index implementation

* chore[documentation]: update existing docs
@lucassouzavieira lucassouzavieira deleted the improved-validation-for-collection-key-options branch October 11, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature/enhancement Request for a new feature or an enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants