refactors on Transaction namespace

Author: lucassouzavieira

src/Transaction/Contracts/Transaction.php

@@ -23,14 +23,14 @@ abstract class Transaction
      *
      * @var Connection
      */
-    protected $connection;
+    protected Connection $connection;
 
     /**
      * StreamTransaction options
      *
      * @var array
      */
-    protected $options;
+    protected array $options;
 
     /**
      * Some default options for transaction
@@ -40,7 +40,7 @@ abstract class Transaction
      *
      * @var array
      */
-    protected $defaultOptions = [
+    protected array $defaultOptions = [
         'maxTransactionSize' => 32000000,
         'waitForSync' => true,
         'allowImplicit' => false,
@@ -54,7 +54,7 @@ abstract class Transaction
      * @param Connection $connection Connection object to use.
      * @param array $options Transaction options.
      *
-     * @throws TransactionException|InvalidParameterException|MissingParameterException
+     * @throws InvalidParameterException|MissingParameterException
      */
     public function __construct(Connection $connection, array $options = [])
     {

src/Transaction/JavascriptTransaction.php

@@ -26,7 +26,7 @@ final class JavascriptTransaction extends Transaction
      *
      * @var string
      */
-    protected $action;
+    protected string $action;
 
     /**
      * JavascriptTransaction constructor.
@@ -35,7 +35,7 @@ final class JavascriptTransaction extends Transaction
      * @param string $action JavaScript code to execute on server
      * @param array $options Transaction options.
      *
-     * @throws TransactionException|InvalidParameterException|MissingParameterException
+     * @throws InvalidParameterException|MissingParameterException
      */
     public function __construct(Connection $connection, string $action, array $options = [])
     {
@@ -50,7 +50,7 @@ public function __construct(Connection $connection, string $action, array $optio
      * @return mixed The result value of transaction
      * @throws TransactionException|GuzzleException
      */
-    public function execute()
+    public function execute(): mixed
     {
         try {
             $options = array_merge($this->options, ['action' => $this->action]);

src/Transaction/StreamTransaction.php

@@ -25,29 +25,29 @@ final class StreamTransaction extends Transaction
      *
      * @var string
      */
-    protected $id;
+    protected string $id;
 
     /**
      * Transaction status
      *
      * @var string
      */
-    protected $status = '';
+    protected string $status = '';
 
     /**
      * If the transaction object is already started
      *
      * @var bool
      */
-    protected $started = false;
+    protected bool $started = false;
 
     /**
      * StreamTransaction constructor.
      *
      * @param Connection $connection Connection object to use.
      * @param array $options Transaction options.
      *
-     * @throws TransactionException|InvalidParameterException|MissingParameterException
+     * @throws InvalidParameterException|MissingParameterException
      */
     public function __construct(Connection $connection, array $options = [])
     {
@@ -79,7 +79,7 @@ public function getTransactionStatus(): string
      *
      * @throws TransactionException|BadResponseException|GuzzleException
      */
-    public function begin()
+    public function begin(): void
     {
         try {
             $response = $this->connection->post(sprintf(Api::TRANSACTION_BEGIN), $this->options);
@@ -91,8 +91,7 @@ public function begin()
         } catch (BadResponseException $exception) {
             // An error was returned from server.
             $response = json_decode((string)$exception->getResponse()->getBody(), true);
-            $transactionException = new TransactionException($response['errorMessage'], $exception, $response['errorNum']);
-            throw $transactionException;
+            throw new TransactionException($response['errorMessage'], $exception, $response['errorNum']);
         }
     }
 
@@ -101,7 +100,7 @@ public function begin()
      *
      * @throws TransactionException|BadResponseException|GuzzleException
      */
-    public function commit()
+    public function commit(): void
     {
         try {
             if ($this->started) {
@@ -127,7 +126,7 @@ public function commit()
      *
      * @throws TransactionException|BadResponseException|GuzzleException
      */
-    public function abort()
+    public function abort(): void
     {
         try {
             if ($this->started) {

src/View/View.php

@@ -76,7 +76,7 @@ class View
      * @param string $type The type of View
      * @param array $attributes View attributes
      *
-     * @see https://www.arangodb.com/docs/stable/arangosearch-views.html#view-properties
+     * @see https://docs.arangodb.com/3.12/index-and-search/arangosearch/arangosearch-views-reference/#view-properties
      */
     public function __construct(string $name, string $type = "arangosearch", array $attributes = [])
     {
@@ -85,8 +85,8 @@ public function __construct(string $name, string $type = "arangosearch", array $
         $this->attributes = array_merge($this->defaults, $attributes);
 
         $this->isNew = true;
-        $this->id = isset($this->attributes['id']) ? $this->attributes['id'] : '';
-        $this->globallyUniqueId = isset($this->attributes['globallyUniqueId']) ? $this->attributes['globallyUniqueId'] : '';
+        $this->id = $this->attributes['id'] ?? '';
+        $this->globallyUniqueId = $this->attributes['globallyUniqueId'] ?? '';
 
         if ($this->id && $this->globallyUniqueId) {
             $this->isNew = false;