small refactor on Graph namespace

Author: lucassouzavieira

src/Database/DatabaseHandler.php

@@ -132,7 +132,7 @@ public static function userDatabases(Connection $connection): ArrayList
      * @return array An array with information about database.
      *
      * @throws GuzzleException|DatabaseException
-     * @see https://www.arangodb.com/docs/stable/http/database-database-management.html#information-of-the-database
+     * @see https://docs.arangodb.com/3.12/develop/http-api/databases/#get-information-about-the-current-database
      */
     public static function current(Connection $connection): array
     {

src/Graph/Graph.php

@@ -118,13 +118,13 @@ public function __construct(string $name, array $attributes = [], Database $data
         $this->isNew = !(isset($attributes['_rev']) && isset($attributes['_id']));
 
         // Set the given options or fallback to a default value.
-        $this->id = isset($attributes['_id']) ? $attributes['_id'] : '';
-        $this->revision = isset($attributes['_rev']) ? $attributes['_rev'] : '';
-        $this->numberOfShards = isset($attributes['numberOfShards']) ? $attributes['numberOfShards'] : 1;
-        $this->replicationFactor = isset($attributes['replicationFactor']) ? $attributes['replicationFactor'] : 1;
-        $this->minReplicationFactor = isset($attributes['minReplicationFactor']) ? $attributes['minReplicationFactor'] : 1;
-        $this->isSmart = isset($attributes['isSmart']) ? $attributes['isSmart'] : false;
-        $this->orphanCollections = isset($attributes['orphanCollections']) ? $attributes['orphanCollections'] : [];
+        $this->id = $attributes['_id'] ?? '';
+        $this->revision = $attributes['_rev'] ?? '';
+        $this->numberOfShards = $attributes['numberOfShards'] ?? 1;
+        $this->replicationFactor = $attributes['replicationFactor'] ?? 1;
+        $this->minReplicationFactor = $attributes['minReplicationFactor'] ?? 1;
+        $this->isSmart = $attributes['isSmart'] ?? false;
+        $this->orphanCollections = $attributes['orphanCollections'] ?? [];
         $this->edgeDefinitions = new ArrayList();
 
         // Edge definitions passed as array.
@@ -301,9 +301,9 @@ public function save(): bool
      *
      * @return bool True if operation was successful, false otherwise.
      *
-     * @throws DatabaseException|GuzzleException|ArangoException
+     * @throws DatabaseException|GuzzleException
      */
-    public function delete($dropCollections = false): bool
+    public function delete(bool $dropCollections = false): bool
     {
         try {
             if (!$this->database) {
@@ -319,7 +319,7 @@ public function delete($dropCollections = false): bool
             $uri = Api::buildSystemUri($connection->getBaseUri(), Api::GRAPH);
             $uri = Api::addUriParam($uri, $this->getName());
             $uri = $dropCollections ? Api::addQuery($uri, ['dropCollections' => $dropCollections]) : $uri;
-            $response = $connection->delete($uri);
+            $connection->delete($uri);
             return true;
         } catch (ClientException $exception) {
             $response = json_decode((string)$exception->getResponse()->getBody(), true);

src/Graph/Traversal/Traversal.php

@@ -27,21 +27,21 @@ class Traversal
      *
      * @var string
      */
-    public const GRAPH_DIRECTION_INBOUND = 'INBOUND';
+    public const string GRAPH_DIRECTION_INBOUND = 'INBOUND';
 
     /**
      * Outbound graph direction.
      *
      * @var string
      */
-    public const GRAPH_DIRECTION_OUTBOUND = 'OUTBOUND';
+    public const string GRAPH_DIRECTION_OUTBOUND = 'OUTBOUND';
 
     /**
      * Any graph direction.
      *
      * @var string
      */
-    public const GRAPH_DIRECTION_ANY = 'ANY';
+    public const string GRAPH_DIRECTION_ANY = 'ANY';
 
     /**
      * The traversal query
@@ -82,24 +82,14 @@ public function __construct(Statement $statement, Connection $connection = null)
         }
     }
 
-    /**
-     * Sets a connection to use for traversal.
-     *
-     * @param Connection $connection
-     */
-    public function setConnection(Connection $connection): void
-    {
-        $this->connection = $connection;
-    }
-
     /**
      * Returns the query,
      *
      * @return string
      *
      * @throws StatementException
      */
-    public function toAql()
+    public function toAql(): string
     {
         return $this->statement->toAql();
     }

tests/Graph/Traversal/PathTest.php

@@ -12,7 +12,7 @@
 
 class PathTest extends BaseGraphTest
 {
-    protected function mockData()
+    protected function mockData(): array
     {
         return [
             'edges' => [

tests/Graph/Traversal/TraversalTest.php

@@ -32,6 +32,6 @@ public function testTraversalQueryThrowException()
 
         $this->expectException(Exception::class);
         $this->expectExceptionMessage("The given Vertex object hasn't a Connection set.");
-        $traversal = Traversal::traversalQuery($vertex, "traversal_test_graph", Traversal::GRAPH_DIRECTION_OUTBOUND, 2);
+        Traversal::traversalQuery($vertex, "traversal_test_graph", Traversal::GRAPH_DIRECTION_OUTBOUND, 2);
     }
 }