fix s3control endpoint override and respect config for mwaa
#91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloutierMat
approved these changes
Nov 28, 2025
Member
cloutierMat
left a comment
cloutierMat
left a comment
There was a problem hiding this comment.
Awesome! Thanks for fixing 🚀
k-a-il
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Terraform provider
v6.23has updated how they deal with tags for the S3 service. They now rely on thes3controlservice for the tagging operations.The following PR localstack/localstack#13435 has added support for those tagging operations, but when @k-a-il tried to run it with
terraform-local, she hit an issue becausetflocalwill override thes3controlendpoint withhttp://localhost:4566and prefix it with the account id of the request, leading to the non-resolvablehttp://000000000000.localhost:4566endpoint.We need to manually override it to a "subdomain compatible" endpoint, our usual
localhost.localstack.cloud, but will respect the user configuration if they set it up to something else. I've also aligned themwaaendpoint to that as well.The new test shows pretty well the "new" / improved behavior.