Skip to content

Conversation

@CoreyHayward
Copy link
Contributor

@CoreyHayward CoreyHayward commented Jul 23, 2025

Resolves #85

This PR addresses a breaking change introduced by a recent update to the python-hcl2 package, as detailed in amplify-education/python-hcl2#242. The issue stemmed from an overlooked new dependency in python-hcl2 which disrupted tflocal's functionality.

To enhance stability and prevent similar issues going forwards, all external dependencies have been pinned. This approach, excluding LocalStack-specific dependencies, allows for more controlled management of updates and mitigates risks associated with unannounced dependency changes.

Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, these are pretty drastic changes. We explicitly do not pin any of these versions, because tflocal is often installed in environments with other Python packages installed. Strictly requiring specific versions of dependencies most certainly creates conflicts in these environments. This is why we cannot / will not pin these dependencies down to a single version.

We could mitigate the issue you are seeing right now by excluding just this one broken version (f.e. like this).
What do you think?

@CoreyHayward
Copy link
Contributor Author

Unfortunately, these are pretty drastic changes. We explicitly do not pin any of these versions, because tflocal is often installed in environments with other Python packages installed. Strictly requiring specific versions of dependencies most certainly creates conflicts in these environments. This is why we cannot / will not pin these dependencies down to a single version.

We could mitigate the issue you are seeing right now by excluding just this one broken version (f.e. like this). What do you think?

Thats fair enough, yep thats a reasonable solution. have updated!

Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution and for the discussion on the topic! The changes are looking good, and I just locally verified the issue and that the new version constraint fixes the import error.
I'll directly move forward, merge the PR, and push a new version.

@alexrashed alexrashed merged commit f9cc8b1 into localstack:main Jul 24, 2025
3 checks passed
@alexrashed
Copy link
Member

FYI: 0.24.1 has just been published on PyPi. Thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unpinned dependencies

3 participants