Fix versioned service endpoints #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloutierMat
approved these changes
Jun 8, 2025
Comment on lines
+137
to
+140
| VERSIONED_SERVICE_EXCLUSIONS = { | ||
| "iotanalytics": {"min": version.Version("0"), "max": version.Version("6.0.0b2")}, | ||
| "iotevents": {"min": version.Version("0"), "max": version.Version("6.0.0b2")}, | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #80, we had an issue with newer beta versions of the AWS Provider, due to some services endpoint being removed.
As we still support them in LocalStack for now, we cannot fully remove those endpoints, and are only removing them if the AWS Provider version is >=
6.0.0-beta2.We are doing by trying to read the
.terraform.lock.hclcreated by theinitcommand, containing the provider version. As the endpoint overrides does not matter for theinitcommand for those endpoints, we should be good to go.I'm not sure there would be a better way to resolve the provider version, and if there even any.