-
-
Notifications
You must be signed in to change notification settings - Fork 0
Enhancement: Declare test code in subdirectory #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
39f14c9 to
f40cd84
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2 +/- ##
========================================
Coverage ? 100.00%
Complexity ? 8
========================================
Files ? 3
Lines ? 16
Branches ? 0
========================================
Hits ? 16
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4e555b5 to
04487a5
Compare
| @@ -1,5 +1,6 @@ | |||
| /.github/ export-ignore | |||
| /.phive/ export-ignore | |||
| /src/Test/ export-ignore | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you work on a package and declare test code in a subdirectory of the production code, adding exclusions for test code in .gitattributes is less work.
| "exclude-from-classmap": [ | ||
| "/src/Test/" | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you declare test code in a subdirectory of production code, managing exclusions for the composer autoloader in composer.json is less work.
| "excludes": [ | ||
| "Test/" | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you declare test code in a subdirectory of production code, managing exclusions for infection/infection in infection.json is less work.
phpunit.xml
Outdated
| <exclude> | ||
| <directory>src/Test/</directory> | ||
| </exclude> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you declare test code in a subdirectory of production code, managing exclusions for collecting code coverage with phpunit/phpunit in phpunit.xml is less work.
15dbde3 to
d4b84dc
Compare
10d1f4a to
fa4d07d
Compare
fa4d07d to
89e324e
Compare
This pull request
src/