Skip to content

Conversation

@localheinz
Copy link
Owner

This pull request

  • declares test code in a subdirectory of src/

@localheinz localheinz self-assigned this Mar 3, 2023
@localheinz localheinz requested a review from ergebnis-bot as a code owner March 3, 2023 08:34
@localheinz localheinz force-pushed the feature/subdirectory branch 3 times, most recently from 39f14c9 to f40cd84 Compare March 3, 2023 08:58
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@d732079). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff            @@
##             main        #2   +/-   ##
========================================
  Coverage        ?   100.00%           
  Complexity      ?         8           
========================================
  Files           ?         3           
  Lines           ?        16           
  Branches        ?         0           
========================================
  Hits            ?        16           
  Misses          ?         0           
  Partials        ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@localheinz localheinz force-pushed the feature/subdirectory branch 5 times, most recently from 4e555b5 to 04487a5 Compare March 3, 2023 09:51
@@ -1,5 +1,6 @@
/.github/ export-ignore
/.phive/ export-ignore
/src/Test/ export-ignore
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you work on a package and declare test code in a subdirectory of the production code, adding exclusions for test code in .gitattributes is less work.

Comment on lines +38 to +40
"exclude-from-classmap": [
"/src/Test/"
]
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you declare test code in a subdirectory of production code, managing exclusions for the composer autoloader in composer.json is less work.

Comment on lines +15 to +17
"excludes": [
"Test/"
]
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you declare test code in a subdirectory of production code, managing exclusions for infection/infection in infection.json is less work.

phpunit.xml Outdated
Comment on lines 28 to 30
<exclude>
<directory>src/Test/</directory>
</exclude>
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you declare test code in a subdirectory of production code, managing exclusions for collecting code coverage with phpunit/phpunit in phpunit.xml is less work.

@localheinz localheinz force-pushed the feature/subdirectory branch 2 times, most recently from 15dbde3 to d4b84dc Compare September 20, 2023 11:19
@localheinz localheinz force-pushed the feature/subdirectory branch 2 times, most recently from 10d1f4a to fa4d07d Compare January 2, 2024 11:14
@localheinz localheinz force-pushed the feature/subdirectory branch from fa4d07d to 89e324e Compare January 2, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants