Skip to content

Conversation

@tankyleo
Copy link
Contributor

@tankyleo tankyleo commented Dec 5, 2025

No description provided.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Dec 5, 2025

👋 I see @wpaulino was un-assigned.
If you'd like another reviewer assignment, please click here.

@tankyleo tankyleo requested a review from wpaulino December 5, 2025 23:07
@tankyleo tankyleo moved this to Goal: Merge in Weekly Goals Dec 5, 2025
@tankyleo tankyleo self-assigned this Dec 5, 2025
@tankyleo
Copy link
Contributor Author

tankyleo commented Dec 5, 2025

Question: if a peer connects to us with splicing on, and quiesence off, should we immediately disconnect ?

@tankyleo tankyleo force-pushed the 25-12-splicing-not-supported branch from 1ffdc82 to cdba25f Compare December 5, 2025 23:19
Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops lol

@codecov
Copy link

codecov bot commented Dec 6, 2025

Codecov Report

❌ Patch coverage is 96.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.33%. Comparing base (109f715) to head (cdba25f).

Files with missing lines Patch % Lines
lightning/src/ln/splicing_tests.rs 95.55% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4262      +/-   ##
==========================================
+ Coverage   89.30%   89.33%   +0.03%     
==========================================
  Files         180      180              
  Lines      139057   139111      +54     
  Branches   139057   139111      +54     
==========================================
+ Hits       124182   124273      +91     
+ Misses      12247    12209      -38     
- Partials     2628     2629       +1     
Flag Coverage Δ
fuzzing 34.99% <45.45%> (-0.01%) ⬇️
tests 88.69% <96.42%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheBlueMatt TheBlueMatt merged commit 3fa7611 into lightningdevkit:main Dec 6, 2025
26 checks passed
@github-project-automation github-project-automation bot moved this from Goal: Merge to Done in Weekly Goals Dec 6, 2025
@tankyleo tankyleo removed the request for review from wpaulino December 6, 2025 03:06
@tankyleo
Copy link
Contributor Author

tankyleo commented Dec 6, 2025

@TheBlueMatt is that a backport to 0.2 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants