Drop deprecated MeshRefinement accessor APIs #4342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These APIs have been deprecated for a very long time (e43e345, Dec 2014), in release 0.9.5 and all subsequent releases. They are therefore also the oldest deprecated code I've run across during the latest cleanup activity. Since we have moved away from reference-returning combined setter/getter APIs recently, and back towards separate APIs for setting and getting internal data (which is what the deprecated code actually did!) I also decided to augment the remaining API with a const reference returning version and an overloaded setter version that takes an input. This seems more consistent with e.g. the more recent MeshBase accessor APIs.
roystgnr
approved these changes
Nov 25, 2025
jwpeterson
deleted the
drop_deprecated_mesh_refinement_enforce_mismatch_accessors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These APIs have been deprecated for a very long time (e43e345, Dec 2014), in release 0.9.5 and all subsequent releases. They are therefore also the oldest deprecated code I've run across during the latest cleanup activity.
Since we have moved away from reference-returning combined setter/getter APIs recently, and back towards separate APIs for setting and getting internal data (which is what the deprecated code actually did!) I also decided to augment the remaining API with a const value returning version and an overloaded setter version that takes an input. This seems more consistent with e.g. the more recent MeshBase accessor APIs.