-
Notifications
You must be signed in to change notification settings - Fork 0
Tw 4 conversion #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lbliii
wants to merge
7
commits into
main
Choose a base branch
from
tw-4-conversion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Tw 4 conversion #11
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,150 @@ | ||
| # Hugo Native Tailwind CSS Setup | ||
|
|
||
| MiloDocs theme now supports Hugo's native Tailwind CSS v4 processing, eliminating the need for separate build tools. | ||
|
|
||
| ## Quick Setup | ||
|
|
||
| ### 1. Install Dependencies | ||
|
|
||
| In your Hugo site root, install the required dependencies: | ||
|
|
||
| ```bash | ||
| npm install -D @tailwindcss/postcss autoprefixer postcss postcss-import tailwindcss | ||
| ``` | ||
|
|
||
| ### 2. Create PostCSS Configuration | ||
|
|
||
| Create `postcss.config.js` in your site root: | ||
|
|
||
| ```javascript | ||
| module.exports = { | ||
| plugins: [ | ||
| require('postcss-import')({ | ||
| path: ['themes/milodocs/assets/css'] | ||
| }), | ||
| require('@tailwindcss/postcss'), | ||
| require('autoprefixer') | ||
| ] | ||
| } | ||
| ``` | ||
|
|
||
| ### 3. Create Tailwind Configuration | ||
|
|
||
| Create `tailwind.config.js` in your site root: | ||
|
|
||
| ```javascript | ||
| /** @type {import('tailwindcss').Config} */ | ||
| module.exports = { | ||
| content: [ | ||
| "content/**/*.md", | ||
| "layouts/**/*.html", | ||
| "themes/milodocs/layouts/**/*.html", | ||
| "themes/milodocs/content/**/*.md", | ||
| "assets/js/**/*.js" | ||
| ], | ||
| theme: { | ||
| extend: { | ||
| colors: { | ||
| brand: "var(--color-brand)", | ||
| "brand-1": "var(--color-brand-1)", | ||
| "brand-2": "var(--color-brand-2)", | ||
| "brand-3": "var(--color-brand-3)", | ||
| "brand-4": "var(--color-brand-4)", | ||
| "brand-5": "var(--color-brand-5)", | ||
| "brand-6": "var(--color-brand-6)", | ||
| "brand-7": "var(--color-brand-7)", | ||
| surface: "var(--color-surface)", | ||
| "surface-hover": "var(--color-surface-hover)", | ||
| "surface-active": "var(--color-surface-active)", | ||
| text: { | ||
| primary: "var(--color-text-primary)", | ||
| secondary: "var(--color-text-secondary)", | ||
| tertiary: "var(--color-text-tertiary)", | ||
| inverse: "var(--color-text-inverse)", | ||
| }, | ||
| bg: { | ||
| primary: "var(--color-bg-primary)", | ||
| secondary: "var(--color-bg-secondary)", | ||
| tertiary: "var(--color-bg-tertiary)", | ||
| inverse: "var(--color-bg-inverse)", | ||
| }, | ||
| border: { | ||
| primary: "var(--color-border-primary)", | ||
| secondary: "var(--color-border-secondary)", | ||
| focus: "var(--color-border-focus)", | ||
| }, | ||
| }, | ||
| fontFamily: { | ||
| "brand": ["NVIDIA", "Arial", "Helvetica", "sans-serif"], | ||
| "nvidia": ["NVIDIA", "Arial", "Helvetica", "sans-serif"], | ||
| "nvidia-mono": ["RobotoMono", "SFMono-Regular", "Menlo", "Monaco", "Consolas", "Liberation Mono", "Courier New", "monospace"], | ||
| }, | ||
| fontSize: { | ||
| 'xs': ['0.875rem', { lineHeight: '1.4' }], | ||
| 'sm': ['0.875rem', { lineHeight: '1.5' }], | ||
| 'base': ['1rem', { lineHeight: '1.6' }], | ||
| 'lg': ['1.125rem', { lineHeight: '1.75' }], | ||
| 'xl': ['1.25rem', { lineHeight: '1.75' }], | ||
| '2xl': ['1.5rem', { lineHeight: '2' }], | ||
| '3xl': ['1.875rem', { lineHeight: '2.25' }], | ||
| }, | ||
| }, | ||
| }, | ||
| plugins: [], | ||
| }; | ||
| ``` | ||
|
|
||
| ### 4. Create Theme Symlink | ||
|
|
||
| For the example site to work, create a symlink to the theme: | ||
|
|
||
| ```bash | ||
| mkdir -p themes | ||
| ln -sf ../../ themes/milodocs | ||
| ``` | ||
|
|
||
| ## How It Works | ||
|
|
||
| 1. **Hugo Processing**: Hugo automatically detects the PostCSS configuration and processes CSS files through PostCSS | ||
| 2. **Tailwind v4**: The `@tailwindcss/postcss` plugin handles Tailwind CSS v4 compilation | ||
| 3. **Component Imports**: PostCSS Import resolves the theme's component CSS files | ||
| 4. **No Build Step**: Everything happens automatically when you run `hugo server` or `hugo build` | ||
|
|
||
| ## Benefits | ||
|
|
||
| - ✅ **No separate build tools**: Hugo handles everything natively | ||
| - ✅ **Live reload**: CSS changes are reflected immediately during development | ||
| - ✅ **Optimized output**: Hugo automatically minifies and fingerprints CSS in production | ||
| - ✅ **Tailwind v4**: Latest Tailwind CSS features and performance improvements | ||
| - ✅ **Theme integration**: Full access to theme components and design tokens | ||
|
|
||
| ## Troubleshooting | ||
|
|
||
| ### CSS Import Errors | ||
|
|
||
| If you see import path errors, ensure: | ||
| 1. The theme symlink exists: `themes/milodocs` → `../../` | ||
| 2. PostCSS import path is configured: `path: ['themes/milodocs/assets/css']` | ||
|
|
||
| ### Missing Dependencies | ||
|
|
||
| Ensure you have Hugo Extended version for PostCSS support: | ||
| ```bash | ||
| hugo version # Should show "extended" | ||
| ``` | ||
|
|
||
| ### Development vs Production | ||
|
|
||
| - **Development**: CSS is processed but not minified for faster builds | ||
| - **Production**: CSS is automatically minified and fingerprinted by Hugo | ||
|
|
||
| ## Migration from PostCSS Build | ||
|
|
||
| If you're migrating from the previous PostCSS build setup: | ||
|
|
||
| 1. Remove build scripts from `package.json` | ||
| 2. Delete generated `assets/css/main.css` | ||
| 3. Remove theme-level `postcss.config.js` and `tailwind.config.js` | ||
| 4. Follow the setup steps above | ||
|
|
||
| The theme now handles CSS processing through Hugo's native capabilities, providing a much cleaner and more maintainable setup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,7 +1,7 @@ | ||||||||||||||||||||
| /* Cards Component - Resource cards, content metadata, and generic card styles */ | ||||||||||||||||||||
|
|
||||||||||||||||||||
| /* Base Card Styles */ | ||||||||||||||||||||
| .card { | ||||||||||||||||||||
| html:not(.no-transitions) .card { | ||||||||||||||||||||
| position: relative; | ||||||||||||||||||||
| /* background: linear-gradient(135deg, var(--color-surface) 0%, var(--color-bg-secondary) 100%); */ | ||||||||||||||||||||
| background: var(--glass-bg); | ||||||||||||||||||||
|
|
@@ -15,7 +15,24 @@ | |||||||||||||||||||
| transition: | ||||||||||||||||||||
| transform var(--timing-medium) var(--easing-standard), | ||||||||||||||||||||
| border-color var(--timing-medium) var(--easing-standard), | ||||||||||||||||||||
| box-shadow var(--timing-medium) var(--easing-standard); | ||||||||||||||||||||
| box-shadow var(--timing-medium) var(--easing-standard), | ||||||||||||||||||||
| background-color var(--timing-medium) var(--easing-standard), | ||||||||||||||||||||
| color var(--timing-medium) var(--easing-standard); | ||||||||||||||||||||
| overflow: hidden; | ||||||||||||||||||||
| /* box-shadow: var(--elevation-2), inset 0 1px 0 rgba(255, 255, 255, 0.1); */ | ||||||||||||||||||||
| box-shadow: var(--glass-shadow); | ||||||||||||||||||||
| } | ||||||||||||||||||||
|
|
||||||||||||||||||||
| .card { | ||||||||||||||||||||
|
||||||||||||||||||||
| position: relative; | ||||||||||||||||||||
| /* background: linear-gradient(135deg, var(--color-surface) 0%, var(--color-bg-secondary) 100%); */ | ||||||||||||||||||||
| background: var(--glass-bg); | ||||||||||||||||||||
| border-radius: var(--radius-card); | ||||||||||||||||||||
| /* border: 1px solid var(--color-border-primary); */ | ||||||||||||||||||||
| border: 1px solid var(--glass-border-color); | ||||||||||||||||||||
| /* backdrop-filter: blur(10px); */ | ||||||||||||||||||||
| -webkit-backdrop-filter: blur(var(--glass-blur)) saturate(var(--glass-saturate)); | ||||||||||||||||||||
| backdrop-filter: blur(var(--glass-blur)) saturate(var(--glass-saturate)); | ||||||||||||||||||||
| overflow: hidden; | ||||||||||||||||||||
| /* box-shadow: var(--elevation-2), inset 0 1px 0 rgba(255, 255, 255, 0.1); */ | ||||||||||||||||||||
| box-shadow: var(--glass-shadow); | ||||||||||||||||||||
|
|
@@ -50,7 +67,14 @@ | |||||||||||||||||||
|
|
||||||||||||||||||||
| /* Resource Card Styles */ | ||||||||||||||||||||
| .card--resource { | ||||||||||||||||||||
| @apply card; | ||||||||||||||||||||
| position: relative; | ||||||||||||||||||||
| background: var(--glass-bg); | ||||||||||||||||||||
| border-radius: var(--radius-card); | ||||||||||||||||||||
| border: 1px solid var(--glass-border-color); | ||||||||||||||||||||
| -webkit-backdrop-filter: blur(var(--glass-blur)) saturate(var(--glass-saturate)); | ||||||||||||||||||||
| backdrop-filter: blur(var(--glass-blur)) saturate(var(--glass-saturate)); | ||||||||||||||||||||
| overflow: hidden; | ||||||||||||||||||||
| box-shadow: var(--glass-shadow); | ||||||||||||||||||||
|
||||||||||||||||||||
| position: relative; | |
| background: var(--glass-bg); | |
| border-radius: var(--radius-card); | |
| border: 1px solid var(--glass-border-color); | |
| -webkit-backdrop-filter: blur(var(--glass-blur)) saturate(var(--glass-saturate)); | |
| backdrop-filter: blur(var(--glass-blur)) saturate(var(--glass-saturate)); | |
| overflow: hidden; | |
| box-shadow: var(--glass-shadow); | |
| /* Only add unique styles here; base card styles are inherited from .card */ |
Outdated
Copilot
AI
Sep 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both .card--resource and .article-card duplicate the same base card properties instead of extending the .card class. This creates maintenance overhead when card styling changes. Consider using @apply card or extending the base card class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| /* Navigation Component - Modular navigation system with NVIDIA styling */ | ||
|
|
||
| /* Import modular navigation components */ | ||
| @import 'navigation/index.css'; | ||
| @import './navigation/index.css'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,10 @@ | ||
| /* Navigation Module - Main import file for all navigation components */ | ||
|
|
||
| /* Import all navigation modules in proper order */ | ||
| @import 'base.css'; | ||
| @import 'chat-toc-toggle.css'; | ||
| @import 'sidebar.css'; | ||
| @import 'topbar.css'; | ||
| @import 'toc.css'; | ||
| @import 'dropdown.css'; | ||
| @import 'language-switcher.css'; | ||
| @import './base.css'; | ||
| @import './chat-toc-toggle.css'; | ||
| @import './sidebar.css'; | ||
| @import './topbar.css'; | ||
| @import './toc.css'; | ||
| @import './dropdown.css'; | ||
| @import './language-switcher.css'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
.cardclass is duplicated with nearly identical properties. The second definition overrides the first, making the conditionalhtml:not(.no-transitions)selector ineffective. Consider consolidating these definitions or using a different approach.