feat: [REL-10579] Add deep link to view a flag in LD for selected project/env #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chdarkly/launchdarkly-toolbar into cspath/REL-10665-display-flag-names
…ink-to-flag-in-LD
…578-copy-flag-key
…ink-to-flag-in-LD
…578-copy-flag-key
…ink-to-flag-in-LD
…ink-to-flag-in-LD
…ble options (#338) * feat: surface variations as selectable options in SDK mode * refactor: use variation value instead of name * refactor: remove console log
…ink-to-flag-in-LD
Contributor
|
Great work @cspath1! I've reviewed the relevant bits here and left a couple of minor comments. Happy to look at it again once the conflicts are resolved but all works as expected 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that we can determine things like the current project key + selected environment, we can link to LaunchDarkly and take the user directly to the flag under the right context (project, env).
What does this PR do?
Provides a way for users to open a flag in LaunchDarkly from the toolbar.
Type of Change
Screenshots/Videos
Related Jira issue: REL-10579: Link to the exact flag in LaunchDarkly with the correct environment