feat: allow clients to evaluate bootstrapped flags when not ready #1036
Conversation
- Introduced `ActiveContextTracker` to manage the current active context and its serialized state. - Updated `LDClientImpl` to utilize the new context tracker for identifying and evaluating flags. - Added logic in `BrowserClientImpl` to read flags from bootstrap data during the initial identification process. This change improves the SDK's ability to handle context and flag management, particularly during initialization.
|
@launchdarkly/browser size report |
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/js-client-sdk-common size report |
|
@launchdarkly/js-client-sdk size report |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| this._eventFactoryDefault.unknownFlagEvent(flagKey, defVal, evalContext), | ||
| ); | ||
|
|
||
| this.emitter.emit('error', this._activeContextTracker.getPristineContext(), error); |
There was a problem hiding this comment.
Bug: Error events emitted with undefined context during pre-initialization evaluation
When evaluating flags before identification completes (using preset bootstrap data), error events for "flag not found" or "wrong type" are emitted via emitter.emit('error', this._activeContextTracker.getPristineContext(), error) where getPristineContext() returns undefined. Previously, _variationInternal returned early when there was no context, so these error events were never emitted in the pre-initialization state. Error listeners that expect a defined context as the first argument may now receive undefined, potentially causing issues in downstream handlers.
Additional Locations (1)
There was a problem hiding this comment.
This is fine as the error is probably due to non-existing context
joker23
force-pushed
the
skz/sdk-1663/active-context-tracking
branch
2 times, most recently
from
53906ff to
48334f3
Compare
joker23
force-pushed
the
skz/sdk-1663/active-context-tracking
branch
from
48334f3 to
1c9cb11
Compare
joker23
force-pushed
the
skz/sdk-1663/active-context-tracking
branch
from
1c9cb11 to
2d45b52
Compare
Related issues
sdk-1653
sdk-1376
sdk-1663
sdk-1681
Describe the solution you've provided
ActiveContextTrackerto manage the current active context and its serialized state.LDClientImplto utilize the new context tracker for identifying and evaluating flags.BrowserClientImplto read flags from bootstrap data during the initial identification process.presetFlagsfunction in client sdk common that allow flagstore to take in contexless data before initializationpresetthe flag store so they can be evaluated before a full context is madeAdditional context
Supersedes #1024
Note
Enables evaluating bootstrapped flags before identify completes by presetting flags and tracking active context; suppresses events without a valid context.
packages/shared/sdk-client):ActiveContextTrackerand switchLDClientImplto use it for pristine/checked contexts and identification promises.presetFlagsinLDClientImplandFlagManagerto load flags without a context; allow evaluations before full initialization (log warnings) and suppress event emission when context is not valid.FlagUpdaterto track the activeContextobject (not just key) and use it for change callbacks andupsertvalidation.packages/sdk/browser):identify, read bootstrap viareadFlagsFromBootstrapandpresetFlagsso flags can be evaluated before identify completes; keep initialization result wiring and goal tracking.identifyresolves.Written by Cursor Bugbot for commit 2d45b52. This will update automatically on new commits. Configure here.