fix: fdv2 datasystem leaves sychronizer open after client is closed #337
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Describe the solution you've provided
This update modifies the runSynchronizers method to ensure that both primary and secondary synchronizers are closed before returning due to a client shutdown.
Describe alternatives you've considered
Alternatively, we could handle the context cancelling in the synchronizer implementation, but this is a less disruptive change.
Additional context
Take a look at jira issue for a more detailed investigation of the problem
Note
Always close primary and secondary synchronizers after processing results, even when context is canceled, to avoid leaving them open after client shutdown.
internal/datasystem/fdv2_datasystem.go):primarySync.Close()andsecondarySync.Close()are invoked immediately afterconsumeSynchronizerResults, before checking forcontext.Canceled.Written by Cursor Bugbot for commit 5a76595. This will update automatically on new commits. Configure here.