Skip to content

Conversation

@joker23
Copy link
Contributor

@joker23 joker23 commented Dec 12, 2025

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Describe the solution you've provided

This update modifies the runSynchronizers method to ensure that both primary and secondary synchronizers are closed before returning due to a client shutdown.

Describe alternatives you've considered

Alternatively, we could handle the context cancelling in the synchronizer implementation, but this is a less disruptive change.

Additional context

Take a look at jira issue for a more detailed investigation of the problem


Note

Always close primary and secondary synchronizers after processing results, even when context is canceled, to avoid leaving them open after client shutdown.

  • FDv2 DataSystem (internal/datasystem/fdv2_datasystem.go):
    • Ensure primarySync.Close() and secondarySync.Close() are invoked immediately after consumeSynchronizerResults, before checking for context.Canceled.
    • Prevents leaving synchronizers running by closing them unconditionally after each sync cycle.

Written by Cursor Bugbot for commit 5a76595. This will update automatically on new commits. Configure here.

This update modifies the runSynchronizers method to ensure that both primary and secondary synchronizers are closed before returning due to a client shutdown.
@joker23 joker23 requested a review from a team as a code owner December 12, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants