-
Notifications
You must be signed in to change notification settings - Fork 78
feat(FR-1726): Auto-populate ENV variables based on selected Inference Runtime Variant #4721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.4% (-0.02% 🔻) |
521/11851 |
| 🔴 | Branches | 3.63% (-0.01% 🔻) |
304/8370 |
| 🔴 | Functions | 2.62% (-0.02% 🔻) |
95/3632 |
| 🔴 | Lines | 4.37% (-0.02% 🔻) |
507/11592 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / runtimeVariantConfigs.ts |
0% | 100% | 0% | 0% |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / EnvVarFormList.tsx |
18% (-9.59% 🔻) |
12.77% (-18% 🔻) |
14.81% (-10.19% 🔻) |
17.02% (-8.9% 🔻) |
Test suite run success
146 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 678781b
48b9212 to
ad4fcd4
Compare
ad4fcd4 to
1190a02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements automatic population of environment variables based on the selected inference runtime variant (vLLM, SGLang, NIM). When users select a runtime variant in the service launcher, the system now automatically adds the required environment variables with appropriate placeholders, improving the user experience and reducing configuration errors.
Key changes:
- Added runtime variant configuration system with predefined environment variables
- Enhanced EnvVarFormList component with AutoComplete functionality for optional environment variables
- Added comprehensive i18n translations across 20+ languages for new environment variable placeholders
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| react/src/helper/runtimeVariantConfigs.ts | New configuration file defining required and optional environment variables for each runtime variant (vllm, sglang, nim) |
| react/src/components/ServiceLauncherPageContent.tsx | Added form value change handler to auto-populate environment variables when runtime variant is selected; improved envvars filtering logic |
| react/src/components/EnvVarFormList.tsx | Enhanced with AutoComplete for variable names, dynamic placeholders based on runtime configs, and improved null safety in filtering |
| resources/i18n/*.json | Added 11 new translation keys for environment variable placeholders (VllmModelName, VllmQuantization, SglangExtraArgs, NimApiKey, etc.) across all supported languages |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
1190a02 to
f1a138e
Compare
ironAiken2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please resolve the confilicts :)
f1a138e to
efb585d
Compare
ironAiken2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once an environment variable is set, its value does not disappear even if I choose a runtime that does not require variables.
efb585d to
06be6d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 25 out of 25 changed files in this pull request and generated no new comments.
06be6d5 to
6008ea8
Compare
…e Runtime Variant
6008ea8 to
678781b
Compare

resolves FR-1726
Enhance Environment Variable Management for Model Services
This PR adds runtime-specific environment variable configurations and improves the environment variable form component with the following features:
These changes make it easier for users to configure model services with the correct environment variables for each runtime type, providing better guidance through placeholders and autocomplete suggestions.
Checklist: