Skip to content

feat(FR-1694): Create a new agent page using the agent_nodes query #4665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
agatha197 wants to merge 1 commit into
base: main
Choose a base branch
from
+1,479 −73
Draft

feat(FR-1694): Create a new agent page using the agent_nodes query #4665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions packages/backend.ai-ui/src/helper/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,38 @@ export const omitNullAndUndefinedFields = <T extends Record<string, any>>(
) as Partial<T>;
};

/**
* Safely parses an unknown input into a plain object record.
*
* Accepts either:
* - a non-null object (not an array) returned as-is
* - a JSON string starting with '{' which will be parsed
* Otherwise returns an empty object.
*
*
* @param raw - Unknown input value that may be an object or JSON string
* @returns A record object or an empty object if parsing fails
*/
export function parseObjectMap<T = any>(raw: unknown): Record<string, T> {
if (!raw) return {};
if (typeof raw === 'object' && raw !== null && !Array.isArray(raw)) {
Copy link

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable 'raw' is of type date, object or regular expression, but it is compared to an expression of type null.

Suggested change
if (typeof raw === 'object' && raw !== null && !Array.isArray(raw)) {
if (
typeof raw === 'object' &&
raw !== null &&
!Array.isArray(raw) &&
(Object.getPrototypeOf(raw) === Object.prototype || Object.getPrototypeOf(raw) === null)
) {

Copilot uses AI. Check for mistakes.
return raw as Record<string, T>;
}
if (typeof raw === 'string') {
const s = raw.trim();
if (!s.startsWith('{')) return {};
try {
const parsed = JSON.parse(s);
if (parsed && typeof parsed === 'object' && !Array.isArray(parsed)) {
return parsed as Record<string, T>;
}
} catch {
return {};
}
}
return {};
}

/**
* Generates a random string of alphabetic characters.
*
Expand Down
12 changes: 6 additions & 6 deletions react/src/components/AgentList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import {
AgentListQuery,
AgentListQuery$data,
} from '../__generated__/AgentListQuery.graphql';
import { AgentSettingModalFragment$key } from '../__generated__/AgentSettingModalFragment.graphql';
import {
convertToBinaryUnit,
convertToDecimalUnit,
Expand All @@ -16,7 +15,7 @@ import { useBAIPaginationOptionStateOnSearchParamLegacy } from '../hooks/reactPa
import { useHiddenColumnKeysSetting } from '../hooks/useHiddenColumnKeysSetting';
import { useThemeMode } from '../hooks/useThemeMode';
import AgentDetailModal from './AgentDetailModal';
import AgentSettingModal from './AgentSettingModal';
import AgentSettingModalLegacy from './AgentSettingModalLegacy';
import BAIIntervalView from './BAIIntervalView';
import BAIProgressWithLabel from './BAIProgressWithLabel';
import BAIRadioGroup from './BAIRadioGroup';
Expand Down Expand Up @@ -47,6 +46,7 @@ import _ from 'lodash';
import React, { useState, useDeferredValue } from 'react';
import { useTranslation } from 'react-i18next';
import { graphql, useLazyLoadQuery } from 'react-relay';
import { AgentSettingModalLegacyFragment$key } from 'src/__generated__/AgentSettingModalLegacyFragment.graphql';
import { StringParam, useQueryParams, withDefault } from 'use-query-params';

type Agent = NonNullable<AgentListQuery$data['agent_list']>['items'][number];
Expand All @@ -71,7 +71,7 @@ const AgentList: React.FC<AgentListProps> = ({
const [currentAgentInfo, setCurrentAgentInfo] =
useState<AgentDetailModalFragment$key | null>();
const [currentSettingAgent, setCurrentSettingAgent] =
useState<AgentSettingModalFragment$key | null>();
useState<AgentSettingModalLegacyFragment$key | null>();
const [visibleColumnSettingModal, { toggle: toggleColumnSettingModal }] =
useToggle();
const baiClient = useSuspendedBackendaiClient();
Expand Down Expand Up @@ -146,7 +146,7 @@ const AgentList: React.FC<AgentListProps> = ({
scaling_group
schedulable
...AgentDetailModalFragment
...AgentSettingModalFragment
...AgentSettingModalLegacyFragment
}
total_count
}
Expand Down Expand Up @@ -960,8 +960,8 @@ const AgentList: React.FC<AgentListProps> = ({
open={!!currentAgentInfo}
onRequestClose={() => setCurrentAgentInfo(null)}
/>
<AgentSettingModal
agentSettingModalFrgmt={currentSettingAgent}
<AgentSettingModalLegacy
agentSettingModalLegacyFrgmt={currentSettingAgent}
open={!!currentSettingAgent}
onRequestClose={(success) => {
if (success) {
Expand Down
Loading