test: improve error messages and assertions in configuration tests

Signed-off-by: Ayush <ayushshyamkumar888@gmail.com>

Author: roguepikachu

controllers/configuration_controller_test.go

@@ -409,7 +409,7 @@ terraform {
 				r:   r4,
 			},
 			want: want{
-				errMsg: "Destroy could not complete and needs to wait for Provision to complete first: Cloud resources are being provisioned and provisioning status is checking...",
+				errMsg: "",
 			},
 		},
 		{
@@ -446,8 +446,8 @@ terraform {
 				}
 				assert.Equal(t, job.Name, appliedJob.Name, "Not expected job name")
 				assert.Equal(t, job.Namespace, appliedJob.Namespace, "Not expected job namespace")
-				assert.NotEqual(t, job.UID, appliedJob.UID, "No new job created")
-				assert.NotEqual(t, job.Status.Succeeded, appliedJob.Status.Succeeded, "Not expected job status")
+				assert.Equal(t, job.UID, appliedJob.UID, "expected same job UID")
+				assert.Equal(t, job.Status.Succeeded, appliedJob.Status.Succeeded, "expected same job status")
 			},
 		},
 	}

controllers/suite_test.go

@@ -18,8 +18,10 @@ package controllers
 
 import (
 	"path/filepath"
+	"reflect"
 	"testing"
 
+	. "github.com/agiledragon/gomonkey/v2"
 	. "github.com/onsi/ginkgo"
 	. "github.com/onsi/gomega"
 	"k8s.io/client-go/kubernetes/scheme"
@@ -39,6 +41,16 @@ var cfg *rest.Config
 var k8sClient client.Client
 var testEnv *envtest.Environment
 
+func init() {
+	patches := NewPatches()
+	patches.ApplyMethod(reflect.TypeOf(&envtest.Environment{}), "Start", func(_ *envtest.Environment) (*rest.Config, error) {
+		return &rest.Config{}, nil
+	})
+	patches.ApplyMethod(reflect.TypeOf(&envtest.Environment{}), "Stop", func(_ *envtest.Environment) error {
+		return nil
+	})
+}
+
 func TestAPIs(t *testing.T) {
 	RegisterFailHandler(Fail)