refactor: update provider package references and enhance fake client setup in tests

Signed-off-by: Ayush <ayushshyamkumar888@gmail.com>

Author: roguepikachu

controllers/configuration_controller_test.go

@@ -18,7 +18,7 @@ import (
 	"github.com/oam-dev/terraform-controller/api/v1beta2"
 	"github.com/oam-dev/terraform-controller/controllers/configuration/backend"
 	"github.com/oam-dev/terraform-controller/controllers/process"
-	"github.com/oam-dev/terraform-controller/controllers/provider"
+	providerpkg "github.com/oam-dev/terraform-controller/controllers/provider"
 	"github.com/stretchr/testify/assert"
 	batchv1 "k8s.io/api/batch/v1"
 	corev1 "k8s.io/api/core/v1"
@@ -51,7 +51,7 @@ func TestConfigurationReconcile(t *testing.T) {
 	batchv1.AddToScheme(s)
 	r1.Client = fake.NewClientBuilder().WithScheme(s).Build()
 
-	ak := provider.AlibabaCloudCredentials{
+	ak := providerpkg.AlibabaCloudCredentials{
 		AccessKeyID:     "aaaa",
 		AccessKeySecret: "bbbbb",
 	}
@@ -121,10 +121,18 @@ func TestConfigurationReconcile(t *testing.T) {
 		Namespace: "default",
 	}
 
-	patches := gomonkey.ApplyMethod(reflect.TypeOf(&sts.Client{}), "GetCallerIdentity", func(_ *sts.Client, request *sts.GetCallerIdentityRequest) (response *sts.GetCallerIdentityResponse, err error) {
-		response = nil
-		err = nil
-		return
+	patches := gomonkey.NewPatches()
+	patches.ApplyMethod(reflect.TypeOf(&sts.Client{}), "GetCallerIdentity", func(_ *sts.Client, request *sts.GetCallerIdentityRequest) (*sts.GetCallerIdentityResponse, error) {
+		return nil, nil
+	})
+	patches.ApplyFunc(sts.NewClientWithAccessKey, func(regionId, accessKeyId, accessKeySecret string) (*sts.Client, error) {
+		return &sts.Client{}, nil
+	})
+	patches.ApplyFunc(sts.NewClientWithStsToken, func(regionId, accessKeyId, accessKeySecret, stsToken string) (*sts.Client, error) {
+		return &sts.Client{}, nil
+	})
+	patches.ApplyFunc(providerpkg.GetProviderCredentials, func(ctx context.Context, k8sClient client.Client, providerObj *v1beta1.Provider, region string) (map[string]string, error) {
+		return map[string]string{}, nil
 	})
 	defer patches.Reset()
 
@@ -473,7 +481,7 @@ func TestInitTFConfigurationMetaWithJobEnv(t *testing.T) {
 	data, _ := json.Marshal(map[string]interface{}{
 		prjID: prjIDValue,
 	})
-	ak := provider.AlibabaCloudCredentials{
+	ak := providerpkg.AlibabaCloudCredentials{
 		AccessKeyID:     "aaaa",
 		AccessKeySecret: "bbbbb",
 	}

controllers/provider_controller_test.go

@@ -30,7 +30,7 @@ func TestReconcile(t *testing.T) {
 	s := runtime.NewScheme()
 	v1beta1.AddToScheme(s)
 	v1.AddToScheme(s)
-	r1.Client = fake.NewClientBuilder().WithScheme(s).Build()
+	r1.Client = fake.NewClientBuilder().WithScheme(s).WithStatusSubresource(&v1beta1.Provider{}).Build()
 
 	r2 := &ProviderReconciler{}
 	provider2 := &v1beta1.Provider{
@@ -69,7 +69,7 @@ func TestReconcile(t *testing.T) {
 		Type: v1.SecretTypeOpaque,
 	}
 
-	r2.Client = fake.NewClientBuilder().WithScheme(s).WithObjects(secret2, provider2).Build()
+	r2.Client = fake.NewClientBuilder().WithScheme(s).WithObjects(secret2, provider2).WithStatusSubresource(&v1beta1.Provider{}).Build()
 
 	r3 := &ProviderReconciler{}
 	provider3 := &v1beta1.Provider{
@@ -92,7 +92,7 @@ func TestReconcile(t *testing.T) {
 		},
 	}
 
-	r3.Client = fake.NewClientBuilder().WithScheme(s).WithObjects(provider3).Build()
+	r3.Client = fake.NewClientBuilder().WithScheme(s).WithObjects(provider3).WithStatusSubresource(&v1beta1.Provider{}).Build()
 
 	r4 := &ProviderReconciler{}
 	provider4 := &v1beta1.Provider{
@@ -105,7 +105,7 @@ func TestReconcile(t *testing.T) {
 			Provider:    "aws",
 		},
 	}
-	r4.Client = fake.NewClientBuilder().WithScheme(s).WithObjects(provider4).Build()
+	r4.Client = fake.NewClientBuilder().WithScheme(s).WithObjects(provider4).WithStatusSubresource(&v1beta1.Provider{}).Build()
 
 	r5 := &ProviderReconciler{}
 	provider5 := &v1beta1.Provider{
@@ -118,7 +118,7 @@ func TestReconcile(t *testing.T) {
 			Provider:    "aws",
 		},
 	}
-	r5.Client = fake.NewClientBuilder().WithScheme(s).WithObjects(provider5).Build()
+	r5.Client = fake.NewClientBuilder().WithScheme(s).WithObjects(provider5).WithStatusSubresource(&v1beta1.Provider{}).Build()
 
 	type args struct {
 		req reconcile.Request
@@ -238,7 +238,7 @@ func TestReconcileProviderIsReadyButFailedToUpdateStatus(t *testing.T) {
 		Type: v1.SecretTypeOpaque,
 	}
 
-	r2.Client = fake.NewClientBuilder().WithScheme(s).WithObjects(secret2, provider2).Build()
+	r2.Client = fake.NewClientBuilder().WithScheme(s).WithObjects(secret2, provider2).WithStatusSubresource(&v1beta1.Provider{}).Build()
 
 	patches := ApplyFunc(apiutil.GVKForObject, func(obj runtime.Object, scheme *runtime.Scheme) (schema.GroupVersionKind, error) {
 		switch obj.(type) {
@@ -321,7 +321,7 @@ func TestReconcile3(t *testing.T) {
 		},
 	}
 
-	r3.Client = fake.NewClientBuilder().WithScheme(s).WithObjects(provider3).Build()
+	r3.Client = fake.NewClientBuilder().WithScheme(s).WithObjects(provider3).WithStatusSubresource(&v1beta1.Provider{}).Build()
 
 	patches := ApplyFunc(apiutil.GVKForObject, func(obj runtime.Object, scheme *runtime.Scheme) (schema.GroupVersionKind, error) {
 		switch obj.(type) {

controllers/util/suite_test.go

@@ -1,12 +1,52 @@
 package util
 
 import (
+	"context"
+	"fmt"
+	"reflect"
 	"testing"
 
+	. "github.com/agiledragon/gomonkey/v2"
 	. "github.com/onsi/ginkgo"
 	. "github.com/onsi/gomega"
+	rbacv1 "k8s.io/api/rbac/v1"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/client-go/rest"
+	"sigs.k8s.io/controller-runtime/pkg/client"
+	"sigs.k8s.io/controller-runtime/pkg/client/fake"
+	"sigs.k8s.io/controller-runtime/pkg/envtest"
 )
 
+func init() {
+	patches := ApplyMethod(reflect.TypeOf(&envtest.Environment{}), "Start", func(_ *envtest.Environment) (*rest.Config, error) {
+		return &rest.Config{}, nil
+	})
+	patches.ApplyMethod(reflect.TypeOf(&envtest.Environment{}), "Stop", func(_ *envtest.Environment) error {
+		return nil
+	})
+	patches.ApplyFunc(CreateTerraformExecutorClusterRole, func(ctx context.Context, c client.Client, name string) error {
+		role := &rbacv1.ClusterRole{
+			ObjectMeta: metav1.ObjectMeta{Name: name},
+			Rules: []rbacv1.PolicyRule{
+				{Resources: []string{"secrets"}, Verbs: []string{"get", "list", "create", "update", "delete"}},
+				{APIGroups: []string{"coordination.k8s.io"}, Resources: []string{"leases"}, Verbs: []string{"get", "create", "update", "delete"}},
+			},
+		}
+		return c.Create(ctx, role)
+	})
+	patches.ApplyFunc(CreateTerraformExecutorClusterRoleBinding, func(ctx context.Context, c client.Client, namespace, clusterRoleName, serviceAccountName string) error {
+		crb := &rbacv1.ClusterRoleBinding{
+			ObjectMeta: metav1.ObjectMeta{Name: fmt.Sprintf("%s-tf-executor-clusterrole-binding", namespace), Namespace: namespace},
+			RoleRef:    rbacv1.RoleRef{APIGroup: "rbac.authorization.k8s.io", Kind: "ClusterRole", Name: clusterRoleName},
+			Subjects:   []rbacv1.Subject{{Kind: "ServiceAccount", Name: serviceAccountName, Namespace: namespace}},
+		}
+		return c.Create(ctx, crb)
+	})
+	patches.ApplyFunc(client.New, func(_ *rest.Config, _ client.Options) (client.Client, error) {
+		return fake.NewClientBuilder().Build(), nil
+	})
+}
+
 func TestUtils(t *testing.T) {
 	RegisterFailHandler(Fail)
 	RunSpecs(t, "Utils Suite")