Skip to content

Conversation

@sniok
Copy link
Contributor

@sniok sniok commented Oct 3, 2025

No description provided.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sniok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2025
@k8s-ci-robot k8s-ci-robot requested a review from knrt10 October 3, 2025 17:26
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 3, 2025
@sniok sniok force-pushed the expose-activity-api branch from 50d0b94 to 3eced91 Compare October 6, 2025 13:10
@sniok sniok requested a review from Copilot October 6, 2025 13:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Expose the Activity API to plugins by exporting Activity, refactoring its Redux slice into a standalone file, and adding documentation plus an example plugin demonstrating usage.

  • Extracted activity state management into activitySlice.tsx and exported Activity to plugin consumers.
  • Added example plugin (activity) and updated typedoc entrypoints and documentation.
  • Updated tests, snapshots, and README indices accordingly.

Reviewed Changes

Copilot reviewed 19 out of 22 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
plugins/headlamp-plugin/src/index.ts Exports Activity for plugin consumption.
plugins/examples/activity/** New example plugin demonstrating Activity API usage.
plugins/README.md Adds link to new example.
frontend/tsconfig.json Includes Activity component for API docs generation.
frontend/src/redux/reducers/reducers.tsx Updates import to use new activitySlice reducer.
frontend/src/plugin/index.ts Exposes Activity via global pluginLib.
frontend/src/plugin/snapshots/pluginLib.snapshot Snapshot updated to include Activity API.
frontend/src/components/activity/activitySlice.tsx New Redux slice for activity state management.
frontend/src/components/activity/Activity.tsx Removes inlined slice; now imports external slice.
frontend/src/components/activity/Activity.test.tsx Adjusts imports to new slice file.
frontend/src/components/activity/Activity.stories.tsx Adjusts imports to new slice file.
docs/development/plugins/functionality/index.md Adds Activity feature documentation.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sniok sniok force-pushed the expose-activity-api branch from 3eced91 to 2715b0e Compare October 6, 2025 13:31
@sniok sniok force-pushed the expose-activity-api branch 2 times, most recently from 80f1252 to d3a1563 Compare October 10, 2025 15:47
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 25, 2025
@sniok sniok force-pushed the expose-activity-api branch from d3a1563 to 6a491a1 Compare December 1, 2025 16:13
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2025
@sniok
Copy link
Contributor Author

sniok commented Dec 1, 2025

this PR is cursed, github action keeps failing because it's running out of space. I'll break it up into two PRs

@sniok sniok closed this Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants