-
Notifications
You must be signed in to change notification settings - Fork 2.8k
refactor(plan): reduce Calculate() cyclomatic complexity #5961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 19599004118Details
💛 - Coveralls |
mloiseleur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it LGTM.
See my suggestion for a minor nitpick.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivankatliarchuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does it do ?
Reduce
plan.Calculate()cyclomatic complexity (was 32).plan.Calculate()is split into 3 new functions:plan.appendTakenDNSNameChangesplan.calculatePlanTableRowChangesplan.appendEndpointUpdatesMotivation
#5419
More