Skip to content

Conversation

@vflaux
Copy link
Contributor

@vflaux vflaux commented Nov 16, 2025

What does it do ?

Reduce plan.Calculate() cyclomatic complexity (was 32).

plan.Calculate() is split into 3 new functions:

  • plan.appendTakenDNSNameChanges
  • plan.calculatePlanTableRowChanges
  • plan.appendEndpointUpdates

Motivation

#5419

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 16, 2025
@k8s-ci-robot k8s-ci-robot added plan Issues or PRs related to external-dns plan size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 16, 2025
@coveralls
Copy link

coveralls commented Nov 16, 2025

Pull Request Test Coverage Report for Build 19599004118

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.009%) to 78.677%

Files with Coverage Reduction New Missed Lines %
openshift_route.go 1 79.49%
plan.go 3 95.85%
Totals Coverage Status
Change from base Build 19598374265: 0.009%
Covered Lines: 15969
Relevant Lines: 20297

💛 - Coveralls

Copy link
Collaborator

@mloiseleur mloiseleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it LGTM.
See my suggestion for a minor nitpick.

@mloiseleur
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2025
@ivankatliarchuk
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2025
@k8s-ci-robot k8s-ci-robot merged commit 00e04e9 into kubernetes-sigs:master Dec 2, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. plan Issues or PRs related to external-dns plan size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants