Skip to content

Conversation

@mloiseleur
Copy link
Collaborator

@mloiseleur mloiseleur commented Oct 4, 2025

What does it do ?

Provide an example on how to test locally External DNS.

Motivation

@TobyTheHutt found an interesting and fast way to test it (source). I would like to share it instead of keeping it hidden in PRs comment.

More

@k8s-ci-robot k8s-ci-robot requested a review from szuecs October 4, 2025 14:02
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 4, 2025
@coveralls
Copy link

coveralls commented Oct 4, 2025

Pull Request Test Coverage Report for Build 20005100362

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 195 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.1%) to 78.684%

Files with Coverage Reduction New Missed Lines %
apis/externaldns/types.go 1 99.71%
plan.go 3 95.85%
source.go 3 83.33%
zz_generated.deepcopy.go 8 0.0%
istio_gateway.go 8 90.1%
txt.go 10 95.28%
endpoint.go 16 90.6%
service.go 20 93.33%
coredns/coredns.go 30 90.36%
gloo_proxy.go 47 74.18%
Totals Coverage Status
Change from base Build 18242454154: 0.1%
Covered Lines: 16009
Relevant Lines: 20346

💛 - Coveralls

Copy link
Member

@ivankatliarchuk ivankatliarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2025
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 7, 2025
@mloiseleur
Copy link
Collaborator Author

@vflaux @ivankatliarchuk Since there is now a nice coredns tutorial, I've updated this PR.
It now just links to it in the dev guide.

@ivankatliarchuk
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2025
@k8s-ci-robot k8s-ci-robot merged commit 71c64e5 into kubernetes-sigs:master Dec 7, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. docs lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants