-
Notifications
You must be signed in to change notification settings - Fork 284
📖Update release documentation #2878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖Update release documentation #2878
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
RELEASE.md
Outdated
| -`git push -u origin release-notes-X.Y.Z` | ||
| - Important! The commit should only contain the release notes file, nothing | ||
| else, otherwise automation will not work. | ||
| - Important! The `origin` must be directed to the fork (for example: nordix) otherwise it will have error. Also, the commit should only contain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep the most important first. Pushing through the fork is normal flow and should not be surprising. Also, maintainers can push directly to upstream (but it is better to go through the fork, since any branch in upstream will get branch protections).
| - Important! The `origin` must be directed to the fork (for example: nordix) otherwise it will have error. Also, the commit should only contain | |
| - Important! The commit should only contain the release notes file, nothing | |
| else, otherwise automation will not work. Push as normal, through your fork (`origin`). |
Signed-off-by: smoshiur1237 <moshiur.rahman@est.tech>
09f9df3 to
0d868a8
Compare
|
/cc @bnallapeta @lentzi90 |
lentzi90
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Some additional info and example to ease future release work