Skip to content

fix(helm): fix objectSelector.matchExpressions indent in webhook.yaml #4480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
taraspos wants to merge 4 commits into
base: main
Choose a base branch
from
+5 −5
Open

fix(helm): fix objectSelector.matchExpressions indent in webhook.yaml #4480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a0cc5a8
Add dummy object selector to tests
taraspos Dec 2, 2025
e594b8c
fix `objectSelector.matchExpressions` indent
taraspos Dec 2, 2025
0123d38
Comment out objectSelector in test.yaml
taraspos Dec 5, 2025
d7e0144
Comment out example objectSelector in test.yaml
taraspos Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions helm/aws-load-balancer-controller/templates/webhook.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,10 @@ webhooks:
{{ end }}
objectSelector:
matchExpressions:
- key: app.kubernetes.io/name
operator: NotIn
values:
- {{ include "aws-load-balancer-controller.name" . }}
- key: app.kubernetes.io/name
operator: NotIn
values:
- {{ include "aws-load-balancer-controller.name" . }}
{{- if .Values.objectSelector.matchExpressions }}
{{- toYaml .Values.objectSelector.matchExpressions | nindent 4 }}
{{- end }}
Expand Down
2 changes: 1 addition & 1 deletion helm/aws-load-balancer-controller/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,4 +356,4 @@ serviceMutatorWebhookConfig:

podMutatorWebhookConfig:
# whether or not to fail the pod creation if the webhook fails
failurePolicy: Ignore
failurePolicy: Ignore