-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[feat gw-api]update reference grant check and route status #4446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat gw-api]update reference grant check and route status #4446
Conversation
| Type: string(gwv1.RouteConditionAccepted), | ||
| Status: metav1.ConditionTrue, | ||
| Reason: string(gwv1.RouteReasonAccepted), | ||
| Message: "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No message?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i felt the status and reason combined is pretty intuitive (accepted=true and resolvedref=true). adding a message is basically just repeating the same thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed with Shelley, seems intuitive you don't need additional info for an accepted status.
9651683 to
fefbf4d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shuqz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
shraddhabang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Description
--default-target-type=ipin deployment, it is overriding the default value. i want to eliminating similar issue to e2e tests by explicitly setting it to instance (just like we set it to ip in ip tests)Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯