-
Notifications
You must be signed in to change notification settings - Fork 1.6k
bump sigs.k8s.io/controller-runtime to v0.19.3 #4011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump sigs.k8s.io/controller-runtime to v0.19.3 #4011
Conversation
shraddhabang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
1a1e2b6 to
10e5f72
Compare
shraddhabang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shraddhabang, zac-nixon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Includes required code changes introduced in controller-runtime `v0.19.3`. Related upstream PR: kubernetes-sigs#4011.
Includes required code changes introduced in controller-runtime `v0.19.z`. Related upstream PR: kubernetes-sigs#4011.
Includes required code changes introduced in controller-runtime `v0.19.z`. Related upstream PR: kubernetes-sigs#4011.
Includes required code changes introduced in controller-runtime `v0.19.z`. Related upstream PR: kubernetes-sigs#4011.
Includes required code changes introduced in controller-runtime `v0.19.z`. Related upstream PR: kubernetes-sigs#4011.
Issue
Pre-req to support the Gateway API: #1338
Description
The gateway api package uses
sigs.k8s.io/controller-runtime v0.19.3https://github.com/kubernetes-sigs/gateway-api/blob/main/go.mod#L21
When trying to pull in the gateway api package, I am unable to do so as the two versions of the controller-runtime are incompatible (0.18 is currently in use by LBC)
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯