Skip to content

Conversation

@DavidXU12345
Copy link
Contributor

Let's refactor command line flags to its own type so that we can just pass Options to driver when constructing a new driver.

Is this a bug fix or adding new feature?
N/A

What is this PR about? / Why do we need it?
As we are adding more and more options in the CLI, let's package all options in its own type with validation.

What testing is done?

  1. set volume-attach-limit-opt-in=true and volume-attach-limit=0
│ E1114 18:42:56.272709       1 main.go:39] "Invalid options" err="volumeAttachLimitOptIn is true, but volumeAttachLimit is not set to a positive value"
  1. set max-inflight-mount-calls-opt-in=true and max-inflight-mount-calls=0
E1114 18:46:47.891407       1 main.go:39] "Invalid options" err="maxInflightMountCallsOptIn is true, but maxInflightMountCalls is not set to a positive value"
  1. e2e test

Let's refactor command line flags to its own type so that we can just
pass Options to driver when constructing a new driver.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidXU12345

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants