Skip to content

feat: add configurable health probes for controller and node components #1720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add configurable health probes for controller and node components #1720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions charts/aws-efs-csi-driver/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
# Helm chart
# v3.2.5
* Add configurable probe support for controller and node components
* Add configurable `livenessProbe`, `readinessProbe`, and `startupProbe` settings
* Maintain backward compatibility by using existing hardcoded values as defaults
* Enable optional readiness and startup probes that can be configured independently
* Support all standard Kubernetes probe configuration options (initialDelaySeconds, timeoutSeconds, periodSeconds, failureThreshold)
# v3.2.4
* Bump app/driver version to `v2.1.13`
# v3.2.3
Expand Down
2 changes: 1 addition & 1 deletion charts/aws-efs-csi-driver/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: aws-efs-csi-driver
version: 3.2.4
version: 3.2.5
appVersion: 2.1.13
kubeVersion: ">=1.17.0-0"
description: "A Helm chart for AWS EFS CSI Driver"
Expand Down
22 changes: 15 additions & 7 deletions charts/aws-efs-csi-driver/templates/controller-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,14 +109,22 @@ spec:
- name: healthz
containerPort: {{ .Values.controller.healthPort }}
protocol: TCP
{{- with .Values.controller.livenessProbe }}
livenessProbe:
httpGet:
path: /healthz
port: healthz
initialDelaySeconds: 10
timeoutSeconds: 3
periodSeconds: 10
failureThreshold: 5
{{- toYaml . | nindent 12 }}
{{- end }}
{{- if .Values.controller.readinessProbe }}
{{- if not (empty .Values.controller.readinessProbe) }}
readinessProbe:
{{- toYaml .Values.controller.readinessProbe | nindent 12 }}
{{- end }}
{{- end }}
{{- if .Values.controller.startupProbe }}
{{- if not (empty .Values.controller.startupProbe) }}
startupProbe:
{{- toYaml .Values.controller.startupProbe | nindent 12 }}
{{- end }}
{{- end }}
{{- with .Values.controller.resources }}
resources: {{ toYaml . | nindent 12 }}
{{- end }}
Expand Down
22 changes: 15 additions & 7 deletions charts/aws-efs-csi-driver/templates/node-daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,14 +120,22 @@ spec:
- name: healthz
containerPort: {{ .Values.node.healthPort }}
protocol: TCP
{{- with .Values.node.livenessProbe }}
livenessProbe:
httpGet:
path: /healthz
port: healthz
initialDelaySeconds: 10
timeoutSeconds: 3
periodSeconds: 2
failureThreshold: 5
{{- toYaml . | nindent 12 }}
{{- end }}
{{- if .Values.node.readinessProbe }}
{{- if not (empty .Values.node.readinessProbe) }}
readinessProbe:
{{- toYaml .Values.node.readinessProbe | nindent 12 }}
{{- end }}
{{- end }}
{{- if .Values.node.startupProbe }}
{{- if not (empty .Values.node.startupProbe) }}
startupProbe:
{{- toYaml .Values.node.startupProbe | nindent 12 }}
{{- end }}
{{- end }}
{{- with .Values.node.resources }}
resources: {{ toYaml . | nindent 12 }}
{{- end }}
Expand Down
54 changes: 54 additions & 0 deletions charts/aws-efs-csi-driver/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,33 @@ controller:
# eks.amazonaws.com/role-arn: arn:aws:iam::111122223333:role/efs-csi-role
healthPort: 9909
regionalStsEndpoints: false
# Liveness probe configuration for the controller
livenessProbe:
httpGet:
path: /healthz
port: healthz
initialDelaySeconds: 10
timeoutSeconds: 3
periodSeconds: 10
failureThreshold: 5
# Readiness probe configuration for the controller (optional)
readinessProbe: {}
# httpGet:
# path: /healthz
# port: healthz
# initialDelaySeconds: 10
# timeoutSeconds: 3
# periodSeconds: 10
# failureThreshold: 3
# Startup probe configuration for the controller (optional)
startupProbe: {}
# httpGet:
# path: /healthz
# port: healthz
# initialDelaySeconds: 10
# timeoutSeconds: 3
# periodSeconds: 10
# failureThreshold: 30
# Pod Disruption Budget
podDisruptionBudget:
enabled: false
Expand Down Expand Up @@ -205,6 +232,33 @@ node:
## Enable if EKS IAM for SA is used
# eks.amazonaws.com/role-arn: arn:aws:iam::111122223333:role/efs-csi-role
healthPort: 9809
# Liveness probe configuration for the node
livenessProbe:
httpGet:
path: /healthz
port: healthz
initialDelaySeconds: 10
timeoutSeconds: 3
periodSeconds: 2
failureThreshold: 5
# Readiness probe configuration for the node (optional)
readinessProbe: {}
# httpGet:
# path: /healthz
# port: healthz
# initialDelaySeconds: 10
# timeoutSeconds: 3
# periodSeconds: 2
# failureThreshold: 3
# Startup probe configuration for the node (optional)
startupProbe: {}
# httpGet:
# path: /healthz
# port: healthz
# initialDelaySeconds: 10
# timeoutSeconds: 3
# periodSeconds: 2
# failureThreshold: 30
# securityContext on the node pod
securityContext:
# The node pod must be run as root to bind to the registration/driver sockets
Expand Down