Skip to content

Fix: Improve RFC3339 date parsing validation (Issue #2418) #2476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2025
Merged

Fix: Improve RFC3339 date parsing validation (Issue #2418) #2476

merged 1 commit into from
Dec 5, 2025
+58 −6

Conversation

@Naman-cell
Copy link
Contributor

@Naman-cell Naman-cell commented Dec 2, 2025 •
edited
Loading

  • Replace search() with fullmatch() for strict RFC3339 format validation
  • Provide clear, actionable error messages with expected format
  • Add input whitespace stripping before validation
  • Improve exception handling with specific ValueError messages
  • Add comprehensive test cases for invalid formats

Test: Existing tests pass + new test cases added

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@Naman-cell
Fix: Improve RFC3339 date parsing validation (Issue kubernetes-client…
31ced98 
…#2418)

- Replace search() with fullmatch() for strict RFC3339 format validation
- Provide clear, actionable error messages with expected format
- Add input whitespace stripping before validation
- Improve exception handling with specific ValueError messages
- Add comprehensive test cases for invalid formats
- Addresses reviewer feedback from PR kubernetes-client#2420

Test: Existing tests pass + new test cases added
@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Dec 2, 2025
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 2, 2025 •
edited
Loading

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: Naman-cell / name: Naman-cell (31ced98)

@k8s-ci-robot k8s-ci-robot added the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Dec 2, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 2, 2025

Welcome @Naman-cell!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 2, 2025
@roycaihw
Copy link
Member

roycaihw commented Dec 4, 2025

/assign @yliaog
Thank you!

@yliaog
Copy link
Contributor

yliaog commented Dec 5, 2025

/release-note NONE

@yliaog
Copy link
Contributor

yliaog commented Dec 5, 2025

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 5, 2025
@yliaog
Copy link
Contributor

yliaog commented Dec 5, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Naman-cell, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2025
@k8s-ci-robot k8s-ci-robot merged commit a49d85d into kubernetes-client:master Dec 5, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabianvf fabianvf Awaiting requested review from fabianvf

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@yliaog yliaog

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Naman-cell @k8s-ci-robot @roycaihw @yliaog