feat: allow to set the cwd in copyFromPod for use in tar

[dherbolt]

It is just a cherry-pick of the original commit

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: dherbolt / name: Daniel Heřbolt (2ecc4b3, 7b041ff, f8283d4, a14aa67, 9d3d472, 1b585ea)

[k8s-ci-robot]

Welcome @dherbolt!

It looks like this is your first PR to kubernetes-client/javascript 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[dherbolt]

Looks like v1.3 uses "tar-fs" instead of the "tar" package, so I'm not sure how many changes it will require.

[cjihrig]

I think we would want this to target the main branch (otherwise, it will get lost again). Also, can you please sign the CLA.

[dherbolt]

I think we would want this to target the main branch (otherwise, it will get lost again). Also, can you please sign the CLA.

Yes, it should also be in the main branch, but as I wrote above, there is a change of npm tar package in the main branch, so it will probably require more changes/testing.

[cjihrig]

there is a change of npm tar package in the main branch

Have you verified that it requires extra changes? It looks like the cwd is only added to a tar system command, and not actually passed to the imported module.

[dherbolt]

there is a change of npm tar package in the main branch

Have you verified that it requires extra changes? It looks like the cwd is only added to a tar system command, and not actually passed to the imported module.

You are right, it does not depend on the tar package. I got somehow confused. sorry.

[mstruebing]

Hey @dherbolt thanks for the PR there are conflicts in the code which needs to be resolved, also there is the cpToPod function which had the optional argument cwd argument as well, I think we should add it there as well.

What would be extra nice would be to have a simple integration test that makes sure it works: https://github.com/kubernetes-client/javascript/blob/main/src/test/integration/index.ts

If you need help or further guidance feel free to ask

[dherbolt]

Hey @dherbolt thanks for the PR there are conflicts in the code which needs to be resolved, also there is the cpToPod function which had the optional argument cwd argument as well, I think we should add it there as well.

What would be extra nice would be to have a simple integration test that makes sure it works: https://github.com/kubernetes-client/javascript/blob/main/src/test/integration/index.ts

If you need help or further guidance feel free to ask

I agree, the copyToPod function should also support cwd argument. Unfornutelly, there is a change in the library used to pack the files ("tar" => "tar-fs"), so I will need more time to find how to pass the cwd arg into it.

[dherbolt]

oh, I have no idea why there are changes in whitespaces after rebase... sorry.

[cjihrig]

Can you back out the unrelated changes in this file and README.md.

[dherbolt]

oh, I have no idea why there are changes in whitespaces after rebase... sorry.

For some unknown reason pre-commit hook reformated those files.

[cjihrig]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjihrig, dherbolt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cjihrig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dherbolt]

Hi @cjihrig is there a plan to add this fix to version 1.1? I can see that it is now part of v1.4, but it would be nice to have it available in older versions because we use Kube 1.32, which is fully compatible with JS client v1.1.
Thanks in advance

[cjihrig]

is there a plan to add this fix to version 1.1?

Not that I am aware of. @brendandburns might be a better person to answer that question. Although, according to the compatibility table, 1.32 and v1.4 should be compatible (the JS client may have additional features, but that shouldn't be a problem).

[dherbolt]

Hmm... with version 1.4 and Kube 1.32, I'm getting an error:

node_modules/@kubernetes/client-node/node_modules/tar-stream/extract.js:292
    cb(this._finished ? null : new Error('Unexpected end of data'))

Looks like the WS connection is closed before all data is sent. I receive only 316 bytes.

[mstruebing]

We have a release-1.1 branch where we could merge commits into it and publish a new 1.1 version i.e. 1.1.3.

Can you try the same from main? There was this PR in between 1.4.0 and now: #2664

[dherbolt]

@mstruebing It would be nice to backport the commits into the 1.1 branch and release it as a patch.
I can confirm the copyFromPod works from main branch.

Thanks in advance.

[mstruebing]

I just tried it and it was relatively easy: #2701