feat: enable new CR-based envelope experience #38

michaelawyu · 2025-04-30T14:02:50Z

Description of your changes

This PR enables the new CR-based envelope experience and removed the support for configMap wrapper

I have:

Run make reviewable to ensure this PR is ready for review.

How has this code been tested

WIP

Special notes for your reviewer

This PR is a WIP; it will be submitted for review when completed.

Signed-off-by: michaelawyu <chenyu1@microsoft.com>

codecov · 2025-04-30T14:44:18Z

Codecov Report

Attention: Patch coverage is 63.15789% with 112 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
apis/placement/v1beta1/zz_generated.deepcopy.go	0.00%	44 Missing ⚠️
pkg/controllers/workgenerator/controller.go	43.54%	29 Missing and 6 partials ⚠️
pkg/controllers/workgenerator/envelope.go	89.18%	15 Missing and 1 partial ⚠️
apis/placement/v1beta1/envelope_types.go	33.33%	12 Missing ⚠️
...lers/clusterresourceplacement/resource_selector.go	0.00%	5 Missing ⚠️

📢 Thoughts on this report? Let us know!

pkg/controllers/workgenerator/controller.go

pkg/controllers/workgenerator/envelope.go

…o feat/enable-new-envelopes

Signed-off-by: Ryan Zhang <zhangryan@microsoft.com>

michaelawyu

Just some minor nits; otherwise LGTM ;)

michaelawyu · 2025-05-15T02:50:34Z

pkg/controllers/workgenerator/manifests/clusterrole.yaml

+rules:
+  - apiGroups: [""]
+    resources: ["pods"]
+    verbs: ["get", "list", "watch"]


Hi Ryan! Just a nit: here needs a new line I assume.

michaelawyu · 2025-05-15T02:51:25Z

pkg/controllers/workgenerator/manifests/webhook.yaml

+        namespace: ops
+    admissionReviewVersions: ["v1"]
+    sideEffects: None
+    timeoutSeconds: 10


Same new line nit.

test/e2e/placement_negative_cases_test.go

michaelawyu · 2025-05-15T02:55:41Z

test/e2e/resources/test-clusterrole.yaml

+rules:
+  - apiGroups: [""]
+    resources: ["pods"]
+    verbs: ["get", "list", "watch"]


The empty line nit stuff.

test/e2e/resources/test-envelope-object.yaml

test/e2e/resources/test-statefulset.yaml

michaelawyu · 2025-05-15T02:58:45Z

apis/placement/v1/clusterresourceplacement_types.go

 	"k8s.io/apimachinery/pkg/util/intstr"
 )

-const (


Hi Ryan! We are removing these as the values in the v1 pkg are not used, right? Do we want to move onto v1 one day?

no, I think we can keep it in v1beta1 forever as v1 always follows v1beta1

michaelawyu · 2025-05-15T03:02:37Z

pkg/utils/apiresources.go

+	r.AddGroupKind(ClusterResourceOverrideGK)
+	r.AddGroupKind(ClusterResourceOverrideSnapshotGK)
+	r.AddGroupKind(ResourceOverrideGK)
+	r.AddGroupKind(ResourceOverrideSnapshotGK)


Ah, we must remember to update this list for every new API types now

yeah, I wish we used a sub group for the envelopType

michaelawyu · 2025-05-15T03:05:13Z

I will do some upgrade compatibility tests to verify the upgrade behavior.

michaelawyu · 2025-05-15T04:13:05Z

It seems that the E2E's still failing; let me fix that, along with the other minor issues I reviewed earlier.

…lawyu/kubefleet into feat/enable-new-envelopes

Signed-off-by: Ryan Zhang <zhangryan@microsoft.com>

Signed-off-by: michaelawyu <chenyu1@microsoft.com>

…lawyu/kubefleet into feat/enable-new-envelopes Signed-off-by: michaelawyu <chenyu1@microsoft.com>

Signed-off-by: michaelawyu <chenyu1@microsoft.com>

Signed-off-by: michaelawyu <chenyu1@microsoft.com> Signed-off-by: Ryan Zhang <zhangryan@microsoft.com> Co-authored-by: Ryan Zhang <zhangryan@microsoft.com> Signed-off-by: Ryan Zhang <zhangryan@microsoft.com>

Signed-off-by: michaelawyu <chenyu1@microsoft.com> Signed-off-by: Ryan Zhang <zhangryan@microsoft.com> Co-authored-by: Ryan Zhang <zhangryan@microsoft.com>

michaelawyu added 2 commits May 1, 2025 00:01

Enabled new envelopes [WIP]

c93a549

Signed-off-by: michaelawyu <chenyu1@microsoft.com>

Minor fixes

6e79b72

Signed-off-by: michaelawyu <chenyu1@microsoft.com>

ryanzhang-oss reviewed Apr 30, 2025

View reviewed changes

pkg/controllers/workgenerator/controller.go Outdated Show resolved Hide resolved

pkg/controllers/workgenerator/controller.go Outdated Show resolved Hide resolved

ryanzhang-oss reviewed May 1, 2025

View reviewed changes

pkg/controllers/workgenerator/envelope.go Outdated Show resolved Hide resolved

pkg/controllers/workgenerator/envelope.go Outdated Show resolved Hide resolved

Ryan Zhang and others added 2 commits April 30, 2025 19:16

add AI test

23dd394

Merge branch 'main' of https://github.com/kubefleet-dev/kubefleet int…

1234f79

…o feat/enable-new-envelopes

ryanzhang-oss force-pushed the feat/enable-new-envelopes branch 4 times, most recently from e360956 to c93b1a4 Compare May 10, 2025 01:40

ryanzhang-oss marked this pull request as ready for review May 12, 2025 22:05

ryanzhang-oss force-pushed the feat/enable-new-envelopes branch 7 times, most recently from 8788261 to f01739d Compare May 14, 2025 21:37

ryanzhang-oss changed the title ~~feat: enable new CR-based envelope experience [WIP]~~ feat: enable new CR-based envelope experience May 14, 2025

add CRD envelop support

8dc5d94

Signed-off-by: Ryan Zhang <zhangryan@microsoft.com>

ryanzhang-oss force-pushed the feat/enable-new-envelopes branch from f01739d to 8dc5d94 Compare May 14, 2025 22:58

Ryan Zhang and others added 2 commits May 14, 2025 16:36

fix e2e

044a175

Signed-off-by: Ryan Zhang <zhangryan@microsoft.com>

Merge branch 'main' into feat/enable-new-envelopes

f1b1bd7

michaelawyu commented May 15, 2025

View reviewed changes

michaelawyu and others added 3 commits May 15, 2025 15:35

Merge branch 'feat/enable-new-envelopes' of https://github.com/michae…

fa33259

…lawyu/kubefleet into feat/enable-new-envelopes

fix the minor issues

76eb13f

Signed-off-by: Ryan Zhang <zhangryan@microsoft.com>

Minor fixes

c75712a

Signed-off-by: michaelawyu <chenyu1@microsoft.com>

michaelawyu added 2 commits May 15, 2025 17:58

Merge branch 'feat/enable-new-envelopes' of https://github.com/michae…

d43bf5c

…lawyu/kubefleet into feat/enable-new-envelopes Signed-off-by: michaelawyu <chenyu1@microsoft.com>

Minor fixes

da750f2

Signed-off-by: michaelawyu <chenyu1@microsoft.com>

ryanzhang-oss approved these changes May 15, 2025

View reviewed changes

ryanzhang-oss merged commit 491abff into kubefleet-dev:main May 15, 2025
16 of 17 checks passed

feat: enable new CR-based envelope experience #38

feat: enable new CR-based envelope experience #38

Uh oh!

Conversation

michaelawyu commented Apr 30, 2025 • edited by ryanzhang-oss Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of your changes

How has this code been tested

Special notes for your reviewer

Uh oh!

codecov bot commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

michaelawyu left a comment

Choose a reason for hiding this comment

Uh oh!

michaelawyu May 15, 2025

Choose a reason for hiding this comment

Uh oh!

michaelawyu May 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

michaelawyu May 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

michaelawyu May 15, 2025

Choose a reason for hiding this comment

Uh oh!

ryanzhang-oss May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

michaelawyu May 15, 2025

Choose a reason for hiding this comment

Uh oh!

ryanzhang-oss May 15, 2025

Choose a reason for hiding this comment

Uh oh!

michaelawyu commented May 15, 2025

Uh oh!

michaelawyu commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

michaelawyu commented Apr 30, 2025 •

edited by ryanzhang-oss

Loading

codecov bot commented Apr 30, 2025 •

edited

Loading

ryanzhang-oss May 15, 2025 •

edited

Loading

michaelawyu commented May 15, 2025 •

edited

Loading