feat: update run abandon implementation #360
Open
+478
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
britaniar
commented
Dec 3, 2025
pkg/controllers/updaterun/abandon.go
Outdated
| ) | ||
|
|
||
| // abandon handles the abandoning of the update run. | ||
| func (r *Reconciler) abandon( |
Collaborator
Author
There was a problem hiding this comment.
taking suggestions on naming this function and the following function as it can used by abandon and pause. Same goes for the file name.
Collaborator
Author
There was a problem hiding this comment.
Thinking pause or halt would be best?
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
britaniar
force-pushed
the
abandonUpdateRun
branch
from
7fd0f54 to
8c18a61
Compare
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Arvindthiru
reviewed
Dec 3, 2025
| Reason: condition.UpdateRunAbandonedReason, | ||
| Message: "The update run has been abandoned", | ||
| }) | ||
| meta.SetStatusCondition(&updateRunStatus.Conditions, metav1.Condition{ |
Collaborator
There was a problem hiding this comment.
What happens if an updateRun is already Succeeded, and then user tries to abandon the updateRun ?
Arvindthiru
reviewed
Dec 3, 2025
| var stuckClusterNames []string | ||
| var clusterUpdateErrors []error | ||
| // Go through each cluster in the stage and check if it's updating/succeeded/failed/not started. | ||
| for i := 0; i < len(updatingStageStatus.Clusters) && clusterUpdatingCount < maxConcurrency; i++ { |
Collaborator
There was a problem hiding this comment.
We don't need to care about maxConcurrency here, since we are not updating any cluster just waiting for them to complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
I have:
Update the abandon state variable name to match description.
Update the controller to take into account when to initialize, execute, abandon.
Created a new file to include all abandon related functions in one place.
Updated integration tests.
Run
make reviewableto ensure this PR is ready for review.How has this code been tested
Will add e2e tests later.
Special notes for your reviewer