fix: fix the validation webhook #359
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com>
ryanzhang-oss
requested review from
Copilot and
zhiying-lin
and removed request for
Copilot
ryanzhang-oss
changed the title
zhiying-lin
reviewed
Dec 4, 2025
Collaborator
zhiying-lin
left a comment
zhiying-lin
left a comment
There was a problem hiding this comment.
Need to update our e2e join & leave tests
| "sigs.k8s.io/controller-runtime/pkg/webhook/admission" | ||
| ) | ||
|
|
||
| func TestHandleDeleteServiceExportValidation(t *testing.T) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| func TestHandleDeleteServiceExportValidation(t *testing.T) { | |
| func TestHandle_Delete(t *testing.T) { |
nit
Comment on lines
+29
to
+32
| networkingEnabled bool | ||
| expectAllowed bool | ||
| expectedMessageSubstr string | ||
| validationMode clusterv1beta1.DeleteValidationMode |
Collaborator
There was a problem hiding this comment.
Suggested change
| networkingEnabled bool | |
| expectAllowed bool | |
| expectedMessageSubstr string | |
| validationMode clusterv1beta1.DeleteValidationMode | |
| networkingEnabled bool | |
| validationMode clusterv1beta1.DeleteValidationMode | |
| wantAllowed bool | |
| wantMessageSubstr string |
prefer "want" instead of expected
Where you would write “actual” and “expected”, prefer using the words “got” and “want”, respectively.
https://google.github.io/styleguide/go/decisions#got-before-want
|
|
||
| resp := validator.Handle(context.Background(), req) | ||
| if resp.Allowed != tc.expectAllowed { | ||
| t.Fatalf("expected allowed=%t but got response: %+v", tc.expectAllowed, resp) |
Collaborator
There was a problem hiding this comment.
Suggested change
| t.Fatalf("expected allowed=%t but got response: %+v", tc.expectAllowed, resp) | |
| t.Fatalf("Handle() got response: %+v, want allowed %t", resp, tc.expectAllowed) |
Test outputs should output the actual value that the function returned before printing the value that was expected. A usual format for printing test outputs is “YourFunc(%v) = %v, want %v”.
| } | ||
| if tc.expectedMessageSubstr != "" { | ||
| if resp.Result == nil || !strings.Contains(resp.Result.Message, tc.expectedMessageSubstr) { | ||
| t.Fatalf("expected message to contain %q but got: %v", tc.expectedMessageSubstr, resp.Result) |
Collaborator
There was a problem hiding this comment.
Suggested change
| t.Fatalf("expected message to contain %q but got: %v", tc.expectedMessageSubstr, resp.Result) | |
| t.Fatalf("Handle() got response result: %v, want contain: %q", resp.Result, tc.expectedMessageSubstr) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Skip the serviceExport check if the neworking is not enabled.
Fixes: When trhe networking is not enabled. The list serviceExport call fails
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer