fix: add label to update run approval object to distinguish between before and after stage tasks #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arvindthiru
reviewed
Dec 2, 2025
britaniar
commented
Dec 3, 2025
britaniar
force-pushed
the
fixBeforeStageTask
branch
from
512b16a to
15931b8
Compare
weng271190436
previously approved these changes
Dec 3, 2025
Arvindthiru
reviewed
Dec 3, 2025
Arvindthiru
reviewed
Dec 3, 2025
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
britaniar
force-pushed
the
fixBeforeStageTask
branch
from
610387c to
c4f5c0a
Compare
jwtty
reviewed
Dec 4, 2025
Arvindthiru
reviewed
Dec 4, 2025
Arvindthiru
reviewed
Dec 4, 2025
jwtty
reviewed
Dec 4, 2025
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
| markUpdateRunWaiting(updateRun, fmt.Sprintf(condition.UpdateRunWaitingMessageFmt, "before-stage", updatingStageStatus.StageName)) | ||
| return false, stageUpdatingWaitTime, nil | ||
| } | ||
| maxConcurrency, err := calculateMaxConcurrencyValue(updateRunStatus, updatingStageIndex) |
Contributor
There was a problem hiding this comment.
why is maxConcurrency calculation included in this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
Fix format/layout of a change I made in a previous PR.
Added a label to update run approval objects to be able to distinguish between before and after stage tasks.
Run
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer