interface: [option 1] udpate placement api to support on demand resourceSnapshot creation #341
+26
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rceSnapshot creation Signed-off-by: Zhiying Lin <zhiyingl456@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Signed-off-by: Zhiying Lin <zhiyingl456@gmail.com>
| // it is greater than the latest resourceSnapshot index. | ||
| // This field is only valid when RolloutStrategyType = RollingUpdate. | ||
| // +kubebuilder:validation:Optional | ||
| ResourceSnapshotIndex *string `json:"resourceSnapshotIndex,omitempty"` |
Contributor
There was a problem hiding this comment.
what if the ResourceSnapshotCreationPolicyType is ondemand? How would a user trigger a snapshot?
Collaborator
Author
There was a problem hiding this comment.
when cx wants to cut the release, they update this field to trigger the snapshot creation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer