Skip to content

Conversation

@michaelawyu
Copy link
Collaborator

@michaelawyu michaelawyu commented Jun 22, 2025

Description of your changes

This PR fixes a variety of issues in the current option that enables usage of priority queue in the work applier, specifically:

  • priority queue is not registered with the controller
  • double enqueueing
  • priority settings are not applied for enqueued items
  • missing support for reportDiff mode
  • incorrent priority assigment

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

N/A; see the notes in the PR.

Special notes for your reviewer

DO NOT MERGE; tests are expected to fail. See the notes in the PR for additional information.

Signed-off-by: michaelawyu <chenyu1@microsoft.com>
@michaelawyu
Copy link
Collaborator Author

At this moment the PR is expected to fail; a potential issue with the priority queue implementation might be blocking our capability to shutdown gracefullly, and consequently the tests might not exit properly.

@michaelawyu
Copy link
Collaborator Author

See also: kubernetes-sigs/controller-runtime#3239 -> will wait until the controller runtime team responds.

Signed-off-by: michaelawyu <chenyu1@microsoft.com>
@michaelawyu
Copy link
Collaborator Author

This PR also bumps the versions of a number of controller-runtime and related deps to verify the behavior of latest code -> this will be properly handled (as a separate PR) depending on the issue resolution progress.

@ryanzhang-oss ryanzhang-oss marked this pull request as draft June 24, 2025 01:41
@michaelawyu
Copy link
Collaborator Author

Progress update (Sep 2, 2025) -> controller-runtime has cut a release (v0.22.0) that features the priority queue fix; however it requires K8s v1.34 API libs. KubeFleet is still currently on v1.32 libs. This PR is on hold until we catches up with v1.34, or controller runtime cuts v0.20.x/v0.21.x that we could use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant