Bug removal and other fixes

Contributing Guidelines.md

@@ -1,6 +1,6 @@
 # Contribution Guidelines
 
-Thanks for taking the time to ontribute! :heart:
+Thanks for taking the time to contribute! :heart:
 
 The following is a set of guidelines for contributing to Face Recognition Attendance System. These are the guidelines, not rules.
 

FRAS/Capture_Image.py

@@ -1,5 +1,5 @@
 import csv
-
+import re
 import cv2
 import os
 
@@ -24,16 +24,37 @@ def is_number(s):
     return False
 
 
+def check_name(name):
+    matches = re.findall(r"^[ A-Za-z]+$", name)
+    if len(matches) > 0:
+        return True
+    return False
+
+
+def check_student_csv_file():
+    try:
+        file = open("StudentDetails"+os.sep+"StudentDetails.csv", 'r+')
+    except FileNotFoundError:
+        with open("StudentDetails"+os.sep+"StudentDetails.csv", 'w') as csvFile:
+            writer = csv.writer(csvFile)
+            writer.writerow(["Id", "Name"])
+    except Exception as e:
+        print(str(e))
+    else:
+        read_csv = csv.reader(file)
+        if not list(read_csv)[0] == ["Id", "Name"]:
+            write_csv = csv.writer(file)
+            write_csv.writerow(["Id", "Name"])
+
 
 # Take image function
 
 def takeImages():
-
 
     Id = input("Enter Your Id: ")
     name = input("Enter Your Name: ")
 
-    if(is_number(Id) and name.isalpha()):
+    if(is_number(Id) and check_name(name)):
         cam = cv2.VideoCapture(0)
         harcascadePath = "haarcascade_frontalface_default.xml"
         detector = cv2.CascadeClassifier(harcascadePath)
@@ -43,33 +64,42 @@ def takeImages():
             ret, img = cam.read()
             gray = cv2.cvtColor(img, cv2.COLOR_BGR2GRAY)
             faces = detector.detectMultiScale(gray, 1.3, 5)
-            for(x,y,w,h) in faces:
+            for(x, y, w, h) in faces:
                 cv2.rectangle(img, (x, y), (x+w, y+h), (255, 0, 0), 2)
-                #incrementing sample number
+                # incrementing sample number
                 sampleNum = sampleNum+1
-                #saving the captured face in the dataset folder TrainingImage
-                cv2.imwrite("TrainingImage" + os.sep +name + "."+Id + '.' +
+                # saving the captured face in the dataset folder TrainingImage
+                cv2.imwrite("TrainingImage" + os.sep + name + "."+Id + '.' +
                             str(sampleNum) + ".jpg", gray[y:y+h, x:x+w])
-                #display the frame
+                # display the frame
                 cv2.imshow('frame', img)
-            #wait for 100 miliseconds
+            # wait for 100 miliseconds
             if cv2.waitKey(100) & 0xFF == ord('q'):
                 break
             # break if the sample number is morethan 100
             elif sampleNum > 60:
                 break
         cam.release()
         cv2.destroyAllWindows()
+
+        # Below function checks if StudentDetails.csv
+        # file exists or Not
+        # if it exists then it will check if
+        # it contains Id, name header or not
+        # if any of the conditions is not met,
+        # it will do the needful
+        check_student_csv_file()
+
         res = "Images Saved for ID : " + Id + " Name : " + name
         row = [Id, name]
         with open("StudentDetails"+os.sep+"StudentDetails.csv", 'a+') as csvFile:
             writer = csv.writer(csvFile)
             writer.writerow(row)
-        csvFile.close()
     else:
         if(is_number(Id)):
             print("Enter Alphabetical Name")
+        elif(not check_name(name)):
+            print("Name can only contain Alphabets and Spaces")
+
         if(name.isalpha()):
             print("Enter Numeric ID")
-
-

FRAS/Recognize.py

@@ -6,7 +6,7 @@
 import pandas as pd
 
 
-#-------------------------
+# -------------------------
 def recognize_attendence():
     recognizer = cv2.face.LBPHFaceRecognizer_create()  # cv2.createLBPHFaceRecognizer()
     recognizer.read("TrainingImageLabel"+os.sep+"Trainner.yml")
@@ -32,6 +32,7 @@ def recognize_attendence():
                 timeStamp = datetime.datetime.fromtimestamp(
                     ts).strftime('%H:%M:%S')
                 aa = df.loc[df['Id'] == Id]['Name'].values
+
                 tt = str(Id)+"-"+aa
                 attendance.loc[len(attendance)] = [Id, aa, date, timeStamp]
 
@@ -51,7 +52,8 @@ def recognize_attendence():
     date = datetime.datetime.fromtimestamp(ts).strftime('%Y-%m-%d')
     timeStamp = datetime.datetime.fromtimestamp(ts).strftime('%H:%M:%S')
     Hour, Minute, Second = timeStamp.split(":")
-    fileName = "Attendance"+os.sep+"Attendance_"+date+"_"+Hour+"-"+Minute+"-"+Second+".csv"
+    fileName = "Attendance"+os.sep+"Attendance_" + \
+        date+"_"+Hour+"-"+Minute+"-"+Second+".csv"
     attendance.to_csv(fileName, index=False)
     cam.release()
     cv2.destroyAllWindows()

FRAS/StudentDetails/StudentDetails.csv

@@ -1,34 +1,2 @@
-Id,Name
-,
-,
-,
-,
-,
-,
-,
-,
-,
-,
-,
-,
-,
-,
-,
-,
-,
-,
-10,Sujon
-,
-11,Kasfia
-1,Mubin
-2,Jacky
-3,Aamir
-4,Tom
-5,Salman
-6,Aksay
-7,Ajay
-9,Sharuk
-12,Bruce
-13,Jonny
-14,Fuad
-15,jawad
+Id,Name
+3442,K. K. Maurya

FRAS/main.py

@@ -3,6 +3,7 @@
 import Capture_Image
 import Train_Image
 import Recognize
+import time
 
 
 # creating the title bar function
@@ -33,40 +34,40 @@ def mainMenu():
     while True:
         try:
             choice = int(input("Enter Choice: "))
-
-            if choice == 1:
-                checkCamera()
-                break
-            elif choice == 2:
-                CaptureFaces()
-                break
-            elif choice == 3:
-                Trainimages()
-                break
-            elif choice == 4:
-                RecognizeFaces()
-                break
-            elif choice == 5:
-                os.system("py automail.py")
-                break
-                mainMenu()
-            elif choice == 6:
-                print("Thank You")
-                break
-            else:
-                print("Invalid Choice. Enter 1-4")
-                mainMenu()
         except ValueError:
-            print("Invalid Choice. Enter 1-4\n Try Again")
-    exit
+            print("Invalid Choice. Enter 1-6\n Try Again")
+        except Exception as e:
+            print(str(e))
+        else:
+            try:
+                if choice == 1:
+                    checkCamera()
+                elif choice == 2:
+                    CaptureFaces()
+                elif choice == 3:
+                    Trainimages()
+                elif choice == 4:
+                    RecognizeFaces()
+                elif choice == 5:
+                    os.system("py automail.py")
+                    mainMenu()
+                elif choice == 6:
+                    print("Thank You")
+                    break
+                else:
+                    print("Invalid Choice. Enter 1-6")
+                    time.sleep(1)
+                    mainMenu()
+            except Exception as e:
+                print("Some Error occurred! - ", str(e))
 
 
 # ---------------------------------------------------------
 # calling the camera test function from check camera.py file
 
 def checkCamera():
     check_camera.camer()
-    key = input("Enter any key to return main menu")
+    input("Enter any key to return main menu")
     mainMenu()
 
 
@@ -75,7 +76,7 @@ def checkCamera():
 
 def CaptureFaces():
     Capture_Image.takeImages()
-    key = input("Enter any key to return main menu")
+    input("Enter any key to return main menu")
     mainMenu()
 
 
@@ -84,7 +85,7 @@ def CaptureFaces():
 
 def Trainimages():
     Train_Image.TrainImages()
-    key = input("Enter any key to return main menu")
+    input("Enter any key to return main menu")
     mainMenu()
 
 
@@ -93,7 +94,7 @@ def Trainimages():
 
 def RecognizeFaces():
     Recognize.recognize_attendence()
-    key = input("Enter any key to return main menu")
+    input("Enter any key to return main menu")
     mainMenu()
 
 

README.md

@@ -1,6 +1,6 @@
 # Face Recognition Attandance System
 
-### Recognize The faces And Take Automatic Attandance. :sparkles:
+### Recognize The faces And Take Automatic Attendance. :sparkles:
 
 ![Face Recognition Logo](https://github.com/kmhmubin/Face-Recognition-Attendance-System/blob/master/Document%20Metarial/Project%20demo%20images/Face-Recognition-Attendance-System-Logo.jpg)
 
@@ -9,7 +9,7 @@
 
 ## Motivation :astonished:
 ----------------------------
-We seek to provide a valuable attendance service for both teachers and students. Reduce manual process errors by provide automated and a reliable attendance system uses face recognition technology.
+We seek to provide a valuable attendance service for both teachers and students. Reduce manual process errors by providing automated and a reliable attendance system which uses face recognition technology.
 
 ## Features :clipboard:
 ---------------------------
@@ -155,7 +155,7 @@ This project have some bugs.
 
 * Student Details: In student details folder the **StudentDetails.csv** file don't have ID & name column.This problem show when the program run first time and create the **StudentDetails.csv** file automatically. To soleve the problelm just open the file and add *ID & Name Column* in the file and save it.
 
-* Auto Attachment: This is not a problem actually. The problem is before sent auto mail we have to manually change the file name. I tried to automate the attachment but i faild.
+* Auto Attachment: This is not a problem actually. The problem is before sent auto mail we have to manually change the file name. I tried to automate the attachment but i failed.
 
 ## Contribute :heart:
 --------------------------------------