Skip to content

Prevent very long titles from overlapping on laptop #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tristantbg wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prevent very long titles from overlapping on laptop #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions field/template.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@
<div class="plugin-prevnext">
<a class="prev" href="<?php echo panel()->urls()->index() . '/pages/' . $prev->id() . '/edit'; ?>">
<i class="fa fa-chevron-left" aria-hidden="true"></i>
<?php echo $prev->title(); ?>
<?php echo $prev->title()->excerpt(50); ?>
</a>

<a class="next" href="<?php echo panel()->urls()->index() . '/pages/' . $next->id() . '/edit'; ?>">
<?php echo $next->title(); ?>
<?php echo $next->title()->excerpt(50); ?>
Copy link
Collaborator

@jenstornell jenstornell Jun 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tristantbg Because of Kirby 3 I will not continue to develop this plugin. It's nice to crop the titles if they are too long, but I think CSS overflow ellipse is a better solution for it. Then it's hidden, not removed which is nicer I think, for hovers ect.

Copy link
Author

@tristantbg tristantbg Jun 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmh yes you're right, it would be more appropriate !

<i class="fa fa-chevron-right" aria-hidden="true"></i>
</a>
</div>
Expand All @@ -34,4 +34,4 @@
}
</style>
<?php
}
}